[PR] Fix commented-out schema config tests [xerces-j]

elharo (via GitHub) <[email protected]> Fri, 17 Jul 2026 14:20:36 -0000
Newsgroups gmane.text.xml.xerces-j.devel
Message-ID <[email protected]>
elharo opened a new pull request, #114:
URL: https://github.com/apache/xerces-j/pull/114

   Fixes 5 of the 6 commented-out tests in `schema.config` that were listed as failing in `build.xml`.
   
   **Root cause analysis:**
   All failures were test bugs, not code bugs:
   
   1. **IgnoreXSIType_C_AC_Test, IgnoreXSIType_C_CA_Test, IgnoreXSIType_C_C_Test** — Expected `VALIDATION_NONE` for elements with declared attributes (`attr="typeY"`). Attribute validation via the anyType wildcard produces `VALIDATION_PARTIAL`. Changed expectations to `VALIDATION_PARTIAL`. The `IGNORE_XSI_TYPE` feature itself works correctly.
   
   2. **UseGrammarPoolOnly_True_Test** — Same pattern: expected `VALIDATION_NONE` but attribute `attr="typeX"` is declared in the grammar pool and validated, producing `VALIDATION_PARTIAL`. Changed expectation to `VALIDATION_PARTIAL`. The `USE_GRAMMAR_POOL_ONLY` feature works correctly (external schemas are not resolved).
   
   3. **UnparsedEntityCheckingTest** — `testDefaultValid()` had a leftover `throw new RuntimeException();` after `checkDefault()` at line 58, causing a test error. Removed it.
   
   4. **SurrogatePairLengthTest** — Passes in isolation but fails in shared-JVM mode (`forkmode="once"`) because `TypeValidator.java:42` reads the property as a `static final` constant at class load time, which happens before the test's static initializer runs when other tests load `TypeValidator` first. Left commented with an explanation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]