Re: [PR] Convert dom.mem.Test to JUnit [xerces-j]

mrglavas (via GitHub) <[email protected]> Fri, 17 Jul 2026 15:09:26 -0000
Newsgroups gmane.text.xml.xerces-j.devel
Message-ID <PR_kwDOLzdO6M7vBPAl-7a5f994a-4ab9-485b-870a-7720735c6e1d@gitbox.apache.org>
mrglavas commented on code in PR #104:
URL: https://github.com/apache/xerces-j/pull/104#discussion_r3604167614


##########
tests/dom/mem/Test.java:
##########
@@ -371,20 +361,20 @@ public static void main(String argv[])
     
     {
         NamedNodeMap    nnm = null;
-        Assertion.verify(nnm == null);
+        assertNull(nnm);
 
         Document        doc = new DocumentImpl();
         nnm = doc.getAttributes();    // Should be null, because node type
                                       //   is not Element.
-        Assertion.verify(nnm == null);
-        Assertion.verify(!(nnm != null));
+        assertNull(nnm);
+        assertNull(nnm);

Review Comment:
   Why are we checking this twice?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]