Re: [PR] Fix IgnoreXSIType and UseGrammarPoolOnly test asser tions (VALIDATION_NONE -> VALIDATION_PARTIAL) [xerces -j]

Copilot commented on code in PR #114:
URL: https://github.com/apache/xerces-j/pull/114#discussion_r3604269705


##########
build.xml:
##########
@@ -837,15 +837,15 @@ Authors:
              <include name="schema/config/RootSimpleTypeDefinitionTest.class"/>
              <include name="schema/config/RootTypeDefinitionTest.class"/>
              <include name="schema/config/UseGrammarPoolOnly_False_Test.class"/>
-          <!-- These tests are failing. Fix them.
-             <include name="schema/config/IgnoreXSIType_C_AC_Test.class"/>
-             <include name="schema/config/IgnoreXSIType_C_CA_Test.class"/>
-             <include name="schema/config/IgnoreXSIType_C_C_Test.class"/>
-             <include name="schema/config/SurrogatePairLengthTest.class"/>
-             <include name="schema/config/UseGrammarPoolOnly_True_Test.class"/>
-             <include name="schema/config/UnparsedEntityCheckingTest.class"/>
-            -->             
-             <include name="jaxp/JAXPSpecTest.class"/>
+              <include name="schema/config/IgnoreXSIType_C_AC_Test.class"/>
+              <include name="schema/config/IgnoreXSIType_C_CA_Test.class"/>
+              <include name="schema/config/IgnoreXSIType_C_C_Test.class"/>
+              <include name="schema/config/UseGrammarPoolOnly_True_Test.class"/>
+           <!-- These tests still need fixes:
+              <include name="schema/config/UnparsedEntityCheckingTest.class"/>
+              <include name="schema/config/SurrogatePairLengthTest.class"/>
+             -->
+              <include name="jaxp/JAXPSpecTest.class"/>

Review Comment:
   The comment block and the following <include> are indented differently than the rest of the <fileset> includes. Keeping indentation consistent reduces noise in future diffs and makes it easier to see which tests are enabled vs disabled.



##########
build.xml:
##########
@@ -837,15 +837,15 @@ Authors:
              <include name="schema/config/RootSimpleTypeDefinitionTest.class"/>
              <include name="schema/config/RootTypeDefinitionTest.class"/>
              <include name="schema/config/UseGrammarPoolOnly_False_Test.class"/>
-          <!-- These tests are failing. Fix them.
-             <include name="schema/config/IgnoreXSIType_C_AC_Test.class"/>
-             <include name="schema/config/IgnoreXSIType_C_CA_Test.class"/>
-             <include name="schema/config/IgnoreXSIType_C_C_Test.class"/>
-             <include name="schema/config/SurrogatePairLengthTest.class"/>
-             <include name="schema/config/UseGrammarPoolOnly_True_Test.class"/>
-             <include name="schema/config/UnparsedEntityCheckingTest.class"/>
-            -->             
-             <include name="jaxp/JAXPSpecTest.class"/>
+              <include name="schema/config/IgnoreXSIType_C_AC_Test.class"/>
+              <include name="schema/config/IgnoreXSIType_C_CA_Test.class"/>
+              <include name="schema/config/IgnoreXSIType_C_C_Test.class"/>
+              <include name="schema/config/UseGrammarPoolOnly_True_Test.class"/>

Review Comment:
   These newly enabled <include> entries have one extra leading space compared to the surrounding includes, which makes the fileset list visually uneven. Align their indentation with the other <include> lines in this block.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]