Re: [PR] [XERCESJ-841] Update VersionNotSupported error message to include XML 1.1 [xerces-j]

elharo (via GitHub) <[email protected]> Sun, 19 Jul 2026 12:36:02 -0000
Newsgroups gmane.text.xml.xerces-j.devel
Message-ID <PR_kwDOLzdO6M7ziJJb-7423bf87-b89c-4ea2-b077-f154cb3f3f9d@gitbox.apache.org>
elharo commented on code in PR #117:
URL: https://github.com/apache/xerces-j/pull/117#discussion_r3610557989


##########
src/org/apache/xerces/impl/msg/XMLMessages.properties:
##########
@@ -105,8 +105,7 @@
         PI_NOT_IN_ONE_ENTITY = The processing instruction is not enclosed in the same entity.
 # 2.8 Prolog and Document Type Declaration
         VersionInfoInvalid = Invalid version \"{0}\".
-        VersionNotSupported = XML version \"{0}\" is not supported, only XML 1.0 is supported.
-        VersionNotSupported11 = XML version \"{0}\" is not supported, only XML 1.0 and XML 1.1 are supported.

Review Comment:
   Is the bug really that we're using VersionNotSupported where we should be using VersionNotSupported11 or is it possible that in the configuration where the bug was found, only XML 1.0 was supported and that part of the bug is invalid?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]