Re: 'border-color' property

Tony Graham <[email protected]>
Newsgroups gmane.text.xml.xmlroff.general
Message-ID <[email protected]>
[email protected] writes:
...
>> Are you ready for 'border-width' and 'border-style'?
>
> Sure.  I've been looking at a lot of the relevant code.  Judging by our
> discussions and looking at the ChangeLog entries for adding border-color, it
> looks like some of the tasks are:
>
> 1. Add border-style and border-width <property>s to spec-dump and add/merge
> the relevant dumped files
>
> 2. Add parallel functions to fo_expr_border_color_eval() and
> eval_border_color_expr() to expr/fo-expr-eval.[ch] for border-style and
> border-width
>
> 3. Add similar code to the border-color patch I submitted to
> fo_context_util_border_resolve() for border-style and border-width
>
> 4. Add lines for border-width and border-style to property/fo-property-eval.c
> (? - spec-dump doesn't generate this, right?)

No, it doesn't, although it easily could, I guess.

>   Correct (I'm just checking here)?  Are there other tasks?
>
>   I can definitely do #3 if it is just duplicating the logic that I added
> for border-color.  I'm not sure I know the mechanics of #1 exactly - running

Yes for #3.

> spec-dump and adding/merging stuff.  I looked at expr/fo-expr-eval.c; I

Just run 'make'.  See the README.  The default target makes the
necessary files.

> might be able to help with #2, but that would be more challenging,

I wouldn't wish #2 on you.  I'll do that.

> especially the lexing/parsing code, I'd think.  #4 looks trivial.

It is.

>   I guess just let me know what you'd like me to work on.

#1, I guess.

You'll need #2 real soon, but you should at least be able to use the
padding evaluation function for 'border-width'.

>   On another note, how do I get the cvs xmlroff/ sources into a
> configure-able/make-able state?  I just did "autoconf configure.in" and it
> yelled at me for some undefined macros.  I can give you details if this is
> news.  I'm not familiar with the autotools etc.

Run autogen.sh.

You may also need to run 'libtoolize' before you run autogen.sh.

Let me know how you get on.

Regards,


Tony.



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.