Re: OOXML RelationshipTransform
Aleksey Sanin <[email protected]> Wed, 10 Feb 2016 07:30:45 -0800
| Newsgroups | gmane.text.xml.xmlsec |
|---|---|
| Message-ID | <[email protected]> |
Absolutely. I still need to update the HACKING and finally remove references to cvs :) Please use pull request on Github instead. I quickly looked through the patch and it looks good overall. There are a few code style differences that needs to be fixed. And there is no test case --- please add it. BTW, I noticed there are other xmlsec patches as well. Would be happy to work with you to merge them as well. Best, Aleksey On 2/10/16 2:46 AM, Miklos Vajna wrote: > Hi, > > When signing OOXML documents, Microsoft uses a RelationshipTransform > algorithm inside the signature. I've implemented this inside libxmlsec > for LibreOffice's needs, here is the patch: > > https://cgit.freedesktop.org/libreoffice/core/tree/external/libxmlsec/xmlsec1-ooxml.patch.1 > > Is there any interest about having this upstream? If so, I would go > through https://github.com/lsh123/xmlsec/blob/master/HACKING and make > sure that the code follows that in the near future, then submit a real > patch here. > > But I didn't want to invest that effort without knowing that in general > a RelationshipTransform implementation is of interest. :-) > > Thanks, > > Miklos > > > > _______________________________________________ > xmlsec mailing list > [email protected] > http://www.aleksey.com/mailman/listinfo/xmlsec > _______________________________________________ xmlsec mailing list [email protected] http://www.aleksey.com/mailman/listinfo/xmlsec