Re: [APC-DEV] APC Wiki
[email protected] (Gopal V) Mon, 18 Aug 2008 18:35:24 +0530
| Newsgroups | php.apc.dev |
|---|---|
| Message-ID | <[email protected]> |
shire wrote: >> I see that you've checked in the new allocator, I'll test it out >> tonight. Also, going to build apc with the new valgrind macros[1] >> to test out for race conditions. Need a better/automated way to run the phpts from Zend ... *sigh*. Will see if I can hack up that fast-cli mode quickly. > I'll test the atomic functions out and add any additional bits I have to > it in the next couple days. I just wanted no refcount++/-- for the update process - increments as you suggest would involve that, to prevent clobbering odd memory during an expunge (and apc_inc in parallel, tiny window after the lock before the ++). > APCIterator code is all checked in now as well. It uses regex_t which is sort of being deprecated all over php land. Here's a quick patch which uses pcre_* instead. And I notice that the iterator destroy leaks out the regex_t anyway (figuring it out for pcre is on my TODO list anyway). http://t3.dotgnu.info/code/apc_iterator_pcre.patch I'd like to remove the smart_str code in there and accept "/[0-9]0/" as a pattern into the iterator, so that everyone's clear that they have to escape slashes. Pierre was rather pointed about ereg/regex_t usage (for the filters). And pcre is a core ext from 5.3 anyway. > I'm also thinking that it would probably be good to get Graham's > optimizer item in as it's not user-facing or affecting anything that'll > break. Sounds like he's willing to make up a patch for it too. Yup, doing an "\0apc_compile_file" constant for him to check which ext was loaded first. Cheers, Gopal -- The difference between insanity and genius is measured by success