Re: [PHP-DEV] [RFC] APC/PHP Lazy Loading

Lukas Kahwe Smith wrote:
>
> On 22.02.2009, at 01:10, shire wrote:
>
>>
>> I've just checked into APC CVS preliminary support for Lazy Loading
>> classes and functions. This means that rather than copying function
>> entries into EG(function_table) and EG(class_table) when an include
>> happen it will mark the functions/classes as available and only
>> actually insert them into the tables when they are called. This is
>> done via hooks added into the various hash table lookups in PHP. I've
>> placed a patch for PHP_5_3 at:
>>
>> http://tekrat.com/downloads/bits/apc_lazy_php53.patch
>
>
> I did not read through the entire thread. As things are close to RC
> state in 5.3, I would prefer to not do any non bug fixes at this stage.
> Then again if the benefits are huge and the risk is low it can be
> considered of course ..


Yep, I should have been clearer here. ;-)   I don't believe this patch is ready to be committed and I'm not advocating for inclusion in the php53 release.  I have some more adjustments I'd like to make to both the APC code and this patch, both for optimization, cleanliness, and to ensure it's the best possible implementation for future enhancements (such as lazy loading methods).  I'm more interested in getting constructive feedback and any benchmark results so I can make adjustments to the current code.  However, I would like to come back with improved patches and get it included in the next major release as appropriate.

I'm all about fixing the remaining php53 todos/bugs and getting this release out!  I hope posting this wasn't a distraction from that.

Thanks!

-shire