Re: 3.0.5 beta

On Sun, 4 Oct 1998, Zeev Suraski wrote:

> At 17:23 04/10/98 +0200, Sascha Schumann wrote:
> >On Sun, 4 Oct 1998, Zeev Suraski wrote:
> >
> >> Ok guys, it was a quick call today :)
> >> 
> >> The 3.0.5 package is at http://il.php.net/distributions/php-3.0.5.tar.gz
> >> 
> >> Please test it and report back on success or failure...
> >
> >The ftp server seems to be down already, the connect times out. Can anyone
> >put it on another ftp?
> 
> It's http only

Thanks for enlighting me. I would have looked more carefully, if the
server would have responded with connection refused ... packet dropping
firewall?

3.0.5 compiled cleanly in the following environment:

- FreeBSD 3.0 (-current) with gcc 2.7.2.1 (that's the one they are
shipping)
- Apache 1.3.2
- Postgres 6.3.2
- imap-4.4.BETA
- gd 1.3

There is a name clash between Apache and Postgres' Libpq (C frontend)
which results in a warning. palloc is defined in libpq-fe.h and
ap_compat.h (this isn't a result of a failure in PHP, of course).

If compiled with -Wall, some more warnings occur:

functions/imap.c uses fs_get() which wasn't declared before. I couldn't
find the proper header file, but it's a defined symbol in c-client.a
(probably due to the beta status of my imap version)

functions/string.c tries to calculate source_end out of a undefined value.
Maybe fix:

--- string.c.orig	Sun Oct  4 18:00:50 1998
+++ string.c	Sun Oct  4 18:01:00 1998
@@ -986,11 +986,11 @@
 
 static void _php3_char_to_str(char *str,uint len,char from,char *to,int to_len,pval *result)
 {
 	int char_count=0;
-	char *source,*target,*tmp,*source_end=source+len;
+	char *source = str,*target,*tmp,*source_end=source+len;
 	
-	for (source=str; *source; source++) {
+	for (; *source; source++) {
 		if (*source==from) {
 			char_count++;
 		}
 	}


     Sascha