Re: Results

At 12:21 04/10/98 -0400, Rasmus Lerdorf wrote:
>> Ok, it was worth it already, it caught the bug in _php3_char_to_str() :)
>
>I am sure this would have been caught regardless.

Well, not if the distribution was already announced and available...

>  We should all be
>compiling with at least -Wall.  And preferably with these as well:
>
> -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations
>
>Simply use: --enable-maintainer-mode --enable-debug
>and you get all these.
>
>These are non-critical, so I didn't clutter my previous report with them,
>but they should be fixed as well:
>
>functions/oci8.c:452: warning: `oci8_ping' defined but not used
>functions/var.c:48: warning: no previous prototype for `php3api_var_dump'
>functions/var.c:125: warning: no previous prototype for `php3_var_dump'
>functions/var.c:151: warning: no previous prototype for
>`php3api_var_serialize'
>functions/var.c:234: warning: no previous prototype for
>`php3api_var_unserialize'
>functions/var.c:346: warning: no previous prototype for `php3_serialize'
>functions/var.c:361: warning: no previous prototype for `php3_unserialize'

Hmm, did somebody fix up all of PHP to compile clean -Wmissing-prototypes?
Never noticed that :)

Zeev
--
Zeev Suraski   <[email protected]>
For a PGP public key, finger [email protected]