#44925 [Asn->Csd]: preg_grep and array index - follow up on #44191

[email protected]
Newsgroups php.bugs
Message-ID <[email protected]>
 ID:          44925
 Updated by:  [email protected]
 Reported By: admin at ifyouwantblood dot de
-Status:      Assigned
+Status:      Closed
 Bug Type:    PCRE related
 PHP Version: 5.2.6
 Assigned To: nlopess
 New Comment:

This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.




Previous Comments:
------------------------------------------------------------------------

[2008-07-17 15:46:26] [email protected]

non, really. It's just that the code will become much bigger to do the
copying :)

------------------------------------------------------------------------

[2008-07-13 16:18:18] [email protected]

Functions should never ever modify the input array unless designed to
do so. According to documentation, preg_grep() is not supposed to modify
the input array. So it's a bug, not BC. What exactly is the usage case
where it should modify input array?

------------------------------------------------------------------------

[2008-07-06 18:46:13] [email protected]

I don't really know what to do with this..
While I agree it shouldn't modify the original array, changing the
behavior would break BC.. Any opinions about this?

------------------------------------------------------------------------

[2008-05-06 16:00:03] admin at ifyouwantblood dot de

> PHP obviously should convert the values to string to be used in
> regex matching. Hence, i think that it should returns the string
> that was matched.

sure, internally it'll has to be converted, but i see no reason for a
change of the input array. thus preg_grep should work with a copy of the
input array...

------------------------------------------------------------------------

[2008-05-06 13:07:09] [email protected]

Well, preg_grep() != in_array()...
PHP obviously should convert the values to string to be used in regex
matching. Hence, i think that it should returns the string that was
matched.

Anyway, i'll assign to the maintainer to solve this issue.

Thanks.

------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
    http://bugs.php.net/44925

-- 
Edit this bug report at http://bugs.php.net/?id=44925&edit=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.