#48740 [Opn]: PHAR install fails when INSTALL_ROOT is not the final install location

[email protected] ("james dot cohen at digitalwindow dot com")
Newsgroups php.bugs
Message-ID <[email protected]>
 ID:               48740
 User updated by:  james dot cohen at digitalwindow dot com
 Reported By:      james dot cohen at digitalwindow dot com
 Status:           Open
 Bug Type:         PHAR related
 Operating System: CentOS release 5.3
 PHP Version:      5.3.0
 New Comment:

--- php-5.3.0/ext/phar/Makefile.frag	2009-06-30 15:01:38.000000000
+0100
+++ php-5.3.0/ext/phar/Makefile.frag.symlink	2009-06-30
15:05:27.000000000 +0100
@@ -43,4 +43,4 @@ $(builddir)/phar.phar: $(builddir)/phar.
 install-pharcmd: pharcmd
 	-@$(mkinstalldirs) $(INSTALL_ROOT)$(bindir)
 	$(INSTALL) $(builddir)/phar.phar $(INSTALL_ROOT)$(bindir)
-	$(LN_S) -f $(INSTALL_ROOT)$(bindir)/phar.phar
$(INSTALL_ROOT)$(bindir)/phar
+	$(LN_S) -f phar.phar $(INSTALL_ROOT)$(bindir)/phar


Previous Comments:
------------------------------------------------------------------------

[2009-06-30 14:00:24] james dot cohen at digitalwindow dot com

Description:
------------
When you run `make install` to install PHAR to a location other than
the final build location an error occurs. Building an RPM within a build
root is a good example of when this might occur.

The bin/phar symbolic link point will point to the build root rather
than the install root.

php-5.3.0/ext/phar/Makefile.frag

Line 46 reads:
$(LN_S) -f $(INSTALL_ROOT)$(bindir)/phar.phar
$(INSTALL_ROOT)$(bindir)/phar

To correct the bug the line should be modified to the following

$(LN_S) -f phar.phar $(INSTALL_ROOT)$(bindir)/phar


This should be safe as both are in the same directory
($(INSTALL_ROOT)$(bindir)/phar)



------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=48740&edit=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.