[PHP-BUG] Bug #51452 [NEW]: 'make install-sapi' tries to execute "" for litespeed, resulting in an error

From:             
Operating system: FreeBSD 8.0-STABLE
PHP version:      5.3.2
Package:          Other web server
Bug Type:         Bug
Bug description:'make install-sapi' tries to execute "" for litespeed, resulting in an error

Description:
------------
Litespeed SAPI generates an error on install due to make trying to execute
an empty variable.

Normally a harmless error, however it results in make returning non-zero
exit status. This breaks the installation from within the Litespeed
webadmin.

From Makefile:

install-sapi: $(OVERALL_TARGET)   
[snip]
        @$(INSTALL_IT)

INSTALL_IT is empty, resulting in:

# make install-sapi
Installing PHP SAPI module:       litespeed
:No such file or directory
*** Error code 1 (continuing)
# make -n install-sapi
echo "Installing PHP SAPI module:       litespeed"
/usr/local/lsws/phpbuild/php-5.2.12/build/shtool mkdir -p
/opt/lsws/lsphp5/bin
if test ! -r /usr/local/lsws/phpbuild/php-5.2.12/libs/libphp5.so; then  for
i in 0.0.0 0.0 0; do  if test -r
/usr/local/lsws/phpbuild/php-5.2.12/libs/libphp5.so.$i; then  ln -s
/usr/local/lsws/phpbuild/php-5.2.12/libs/libphp5.so.$i
/usr/local/lsws/phpbuild/php-5.2.12/libs/libphp5.so;  break;  fi;  done; 
fi

#

Notice the empty line in the -n output.

Setting INSTALL_IT to a dummy command (INSTALL_IT="@true") in
sapi/litespeed/config.m4 fixes this.

Additionally, 'make install-sapi' doesn't even really install anything for
litespeed, because their webadmin scripts copy the binary directly from the
build directory to where it needs to be (which is not at $prefix). As
usually you'd expect a compiled binary to end up in $prefix/bin after
installation I propose fixing this so it actually installs something.

Ideally the Litespeed scripts should then copy the binary from $prefix/bin
instead of from the build directory.

A patch that fixes this bug is attached, it also installs the binary to
$prefix/bin/lsphp.


-- 
Edit bug report at http://bugs.php.net/bug.php?id=51452&edit=1
-- 
Try a snapshot (PHP 5.2):            http://bugs.php.net/fix.php?id=51452&r=trysnapshot52
Try a snapshot (PHP 5.3):            http://bugs.php.net/fix.php?id=51452&r=trysnapshot53
Try a snapshot (PHP 6.0):            http://bugs.php.net/fix.php?id=51452&r=trysnapshot60
Fixed in SVN:                        http://bugs.php.net/fix.php?id=51452&r=fixed
Fixed in SVN and need be documented: http://bugs.php.net/fix.php?id=51452&r=needdocs
Fixed in release:                    http://bugs.php.net/fix.php?id=51452&r=alreadyfixed
Need backtrace:                      http://bugs.php.net/fix.php?id=51452&r=needtrace
Need Reproduce Script:               http://bugs.php.net/fix.php?id=51452&r=needscript
Try newer version:                   http://bugs.php.net/fix.php?id=51452&r=oldversion
Not developer issue:                 http://bugs.php.net/fix.php?id=51452&r=support
Expected behavior:                   http://bugs.php.net/fix.php?id=51452&r=notwrong
Not enough info:                     http://bugs.php.net/fix.php?id=51452&r=notenoughinfo
Submitted twice:                     http://bugs.php.net/fix.php?id=51452&r=submittedtwice
register_globals:                    http://bugs.php.net/fix.php?id=51452&r=globals
PHP 4 support discontinued:          http://bugs.php.net/fix.php?id=51452&r=php4
Daylight Savings:                    http://bugs.php.net/fix.php?id=51452&r=dst
IIS Stability:                       http://bugs.php.net/fix.php?id=51452&r=isapi
Install GNU Sed:                     http://bugs.php.net/fix.php?id=51452&r=gnused
Floating point limitations:          http://bugs.php.net/fix.php?id=51452&r=float
No Zend Extensions:                  http://bugs.php.net/fix.php?id=51452&r=nozend
MySQL Configuration Error:           http://bugs.php.net/fix.php?id=51452&r=mysqlcfg