Bug #71214 [Opn->Csd]: foreach() with inline assignment breaks references

[email protected] ("bugs dot php dot net at ss dot st dot tc")
Newsgroups php.bugs
Message-ID <[email protected]>
Edit report at https://bugs.php.net/bug.php?id=71214&edit=1

 ID:                 71214
 User updated by:    bugs dot php dot net at ss dot st dot tc
 Reported by:        bugs dot php dot net at ss dot st dot tc
 Summary:            foreach() with inline assignment breaks references
-Status:             Open
+Status:             Closed
 Type:               Bug
 Package:            Scripting Engine problem
 Operating System:   Linux, OSX
 PHP Version:        7.0.1
 Block user comment: N
 Private report:     N

 New Comment:

(sorry, wrong test script, closing)


Previous Comments:
------------------------------------------------------------------------
[2015-12-24 19:49:06] bugs dot php dot net at ss dot st dot tc

Description:
------------
I believe both PHP 5.6 and 7 have bugs, but also they behave differently.
Tested on PHP 5.6.12, 5.6.16, 7.0.0, 7.0.1.


Test script:
---------------
<?php

# source array that we'll reference to later
$source = [ 'subarray' => ['item' => 'old value ---'] ];


# $ref1 is a reference to $source, assigned right in the foreach()
foreach ( $ref1 = $source as &$subarray ) {
	$subarray['item'] = 'NEW value';
	echo $subarray['item'], PHP_EOL;
	echo $ref1['subarray']['item'], PHP_EOL;
}
echo PHP_EOL;


# $ref2 is a "normal" reference to $source
$ref2 = $source;
foreach ( $ref2 as &$subarray ) {
	$subarray['item'] = 'NEW value';
	echo $subarray['item'], PHP_EOL;
	echo $ref2['subarray']['item'], PHP_EOL;
}
echo PHP_EOL;


########################################

# similar to $source array, but done using a function
function getSource() {
	return [ 'subarray' => ['item' => 'old value ---'] ];
}


# $ref3 is a reference to a result of getSource(), assigned right in the foreach()
foreach ( $ref3 = getSource() as &$subarray ) {
	$subarray['item'] = 'NEW value';
	echo $subarray['item'], PHP_EOL;
	echo $ref3['subarray']['item'], PHP_EOL;
}
echo PHP_EOL;


# $ref4 is a "normal" reference to a result of getSource()
$ref4 = getSource();
foreach ( $ref4 as &$subarray ) {
	$subarray['item'] = 'NEW value';
	echo $subarray['item'], PHP_EOL;
	echo $ref3['subarray']['item'], PHP_EOL;
}


Expected result:
----------------
both PHP 5 and 7:

NEW value
NEW value

NEW value
NEW value

NEW value
NEW value

NEW value
NEW value

Actual result:
--------------
PHP 7: 

NEW value
old value ---

NEW value
NEW value

NEW value
old value ---

NEW value
old value ---


PHP 5:

NEW value
old value ---

NEW value
NEW value

NEW value
NEW value

NEW value
NEW value


------------------------------------------------------------------------



--
Edit this bug report at https://bugs.php.net/bug.php?id=71214&edit=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.