[php-src] Issue #21958: mbstring: Do functions marked “TODO Return void” require an RFC to change return type?

[email protected] (arshidkv12)
Newsgroups php.bugs
Message-ID <[email protected]>
Issue: https://github.com/php/php-src/issues/21958
Author: arshidkv12

Hi,

In **ext/mbstring/php_mbregex.c**, I noticed several places with comments like:

// TODO Return void
**RETURN_TRUE**;

[ext/mbstring/php_mbregex.c:1567](https://github.com/php/php-src/blob/master/ext/mbstring/php_mbregex.c#L1567)

This suggests the intent is to change these functions to return void instead of bool.

Before preparing a patch, I wanted to confirm the process:

Would changing these functions from returning true to void (i.e., RETURN_NULL() in C and updating stubs to: void) require an RFC?
Or is this considered a minor/internal API cleanup that can go directly as a PR?

I’m aware that this could have a userland impact if the return value is currently used, so I wanted to check what the preferred approach is.

Happy to prepare a PR once the direction is clarified.

Thanks!
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.