[PHP-CVS] [php-src] master: Applied fixers to improve test robustness (ext/intl, ext/phar) (#22985)

[email protected] (NickSdot via GitHub) Sat, 1 Aug 2026 11:05:27 +0000
Newsgroups php.cvs
Message-ID <[email protected]> 
Author: NickSdot (NickSdot)
Committer: GitHub (web-flow)
Pusher: LamentXU123
Date: 2026-08-01T19:05:24+08:00

Commit: https://github.com/php/php-src/commit/7334dcf5cc9cfd4f5cbf3e6bf34176da2f8498cc
Raw diff: https://github.com/php/php-src/commit/7334dcf5cc9cfd4f5cbf3e6bf34176da2f8498cc.diff

Applied fixers to improve test robustness (ext/intl, ext/phar) (#22985)

This commit hardens tests in the phar and intl extension. By:
- Testing exception type in error tests, and formating them consistently.
- Removing useless blank lines

Changed paths:
  M  ext/intl/tests/breakiter_getPartsIterator_error.phpt
  M  ext/intl/tests/bug48227.phpt
  M  ext/intl/tests/bug61487.phpt
  M  ext/intl/tests/bug62083.phpt
  M  ext/intl/tests/bug74063.phpt
  M  ext/intl/tests/calendar_clear_error.phpt
  M  ext/intl/tests/calendar_createInstance_error.phpt
  M  ext/intl/tests/calendar_getDayOfWeekType_error.phpt
  M  ext/intl/tests/calendar_getWeekendTransition_error.phpt
  M  ext/intl/tests/calendar_get_Least_Greatest_Minimum_Maximum_error.phpt
  M  ext/intl/tests/calendar_get_getActualMaximum_Minumum_error.phpt
  M  ext/intl/tests/calendar_get_getActualMaximum_Minumum_error2.phpt
  M  ext/intl/tests/calendar_isSet_error.phpt
  M  ext/intl/tests/calendar_roll_error.phpt
  M  ext/intl/tests/calendar_setFirstDayOfWeek_error.phpt
  M  ext/intl/tests/calendar_setMinimalDaysInFirstWeek_error.phpt
  M  ext/intl/tests/calendar_setSkipped_RepeatedWallTimeOption_error.phpt
  M  ext/intl/tests/calendar_set_date_out_of_bounds.phpt
  M  ext/intl/tests/calendar_set_date_time_out_of_bounds.phpt
  M  ext/intl/tests/calendar_set_error.phpt
  M  ext/intl/tests/calendar_set_out_of_bounds.phpt
  M  ext/intl/tests/calendar_uninitialized_argument_position.phpt
  M  ext/intl/tests/collator_double_ctor.phpt
  M  ext/intl/tests/collator_sort_conversion_error_exception.phpt
  M  ext/intl/tests/collator_sort_tostring_throws.phpt
  M  ext/intl/tests/datefmt_parse_localtime_offset_type_error.phpt
  M  ext/intl/tests/dateformat___construct_bad_tz_cal.phpt
  M  ext/intl/tests/dateformat_get_set_calendar_variant_icu70.phpt
  M  ext/intl/tests/dateformat_get_set_timezone_variant5.phpt
  M  ext/intl/tests/dateformat_set_timezone_id_icu72-1.phpt
  M  ext/intl/tests/formatter_format_and_parse_errors.phpt
  M  ext/intl/tests/formatter_format_decimal_compact.phpt
  M  ext/intl/tests/gh12243.phpt
  M  ext/intl/tests/gh12282.phpt
  M  ext/intl/tests/gh12727.phpt
  M  ext/intl/tests/gh13766.phpt
  M  ext/intl/tests/gh17469.phpt
  M  ext/intl/tests/grapheme_levenshtein.phpt
  M  ext/intl/tests/grapheme_out_of_bounds.phpt
  M  ext/intl/tests/gregoriancalendar___construct_error.phpt
  M  ext/intl/tests/gregoriancalendar___construct_out_of_bounds.phpt
  M  ext/intl/tests/gregoriancalendar_set_date_error.phpt
  M  ext/intl/tests/gregoriancalendar_set_date_time_error.phpt
  M  ext/intl/tests/ini_use_exceptions_basic.phpt
  M  ext/intl/tests/listformatter/listformatter_clone.phpt
  M  ext/intl/tests/listformatter/listformatter_double_ctor.phpt
  M  ext/intl/tests/listformatter/listformatter_error.phpt
  M  ext/intl/tests/listformatter/listformatter_with_parameters_error.phpt
  M  ext/intl/tests/locale_filter_matches_icu70.phpt
  M  ext/intl/tests/locale_get_all_variants.phpt
  M  ext/intl/tests/locale_get_display_keyword_null_bytes.phpt
  M  ext/intl/tests/locale_get_display_language4.phpt
  M  ext/intl/tests/locale_get_display_script4.phpt
  M  ext/intl/tests/locale_get_region.phpt
  M  ext/intl/tests/locale_get_script.phpt
  M  ext/intl/tests/locale_is_right_to_left.phpt
  M  ext/intl/tests/locale_lookup_invalid_language_tag.phpt
  M  ext/intl/tests/locale_lookup_variant3.phpt
  M  ext/intl/tests/locale_set_default.phpt
  M  ext/intl/tests/msgfmt_bug70484.phpt
  M  ext/intl/tests/numfmt_parse_currency_references.phpt
  M  ext/intl/tests/rangeformatter/rangeformatter_errors.phpt
  M  ext/intl/tests/rbbiter___construct_basic.phpt
  M  ext/intl/tests/resourcebundle_double_ctor.phpt
  M  ext/intl/tests/spoofchecker_008.phpt
  M  ext/intl/tests/spoofchecker_double_ctor.phpt
  M  ext/intl/tests/spoofchecker_unknown_restriction_level.phpt
  M  ext/phar/tests/002.phpt
  M  ext/phar/tests/004.phpt
  M  ext/phar/tests/005.phpt
  M  ext/phar/tests/006.phpt
  M  ext/phar/tests/007.phpt
  M  ext/phar/tests/008.phpt
  M  ext/phar/tests/009.phpt
  M  ext/phar/tests/010.phpt
  M  ext/phar/tests/011.phpt
  M  ext/phar/tests/029.phpt
  M  ext/phar/tests/030.phpt
  M  ext/phar/tests/032.phpt
  M  ext/phar/tests/033a.phpt
  M  ext/phar/tests/addfuncs.phpt
  M  ext/phar/tests/alias_acrobatics.phpt
  M  ext/phar/tests/badparameters.phpt
  M  ext/phar/tests/bug13786.phpt
  M  ext/phar/tests/bug45218_SLOWTEST.phpt
  M  ext/phar/tests/bug48377.2.phpt
  M  ext/phar/tests/bug48377.phpt
  M  ext/phar/tests/bug54395.phpt
  M  ext/phar/tests/bug60261.phpt
  M  ext/phar/tests/bug64931/bug64931.phpt
  M  ext/phar/tests/bug65028.phpt
  M  ext/phar/tests/bug65414.phpt
  M  ext/phar/tests/bug69324.phpt
  M  ext/phar/tests/bug71498.phpt
  M  ext/phar/tests/bug72321.phpt
  M  ext/phar/tests/bug72928.phpt
  M  ext/phar/tests/bug73035.phpt
  M  ext/phar/tests/bug73764.phpt
  M  ext/phar/tests/bug73768.phpt
  M  ext/phar/tests/bug73809.phpt
  M  ext/phar/tests/bug77143.phpt
  M  ext/phar/tests/bug77247.phpt
  M  ext/phar/tests/bug77396.phpt
  M  ext/phar/tests/bug79503.phpt
  M  ext/phar/tests/bug81211.phpt
  M  ext/phar/tests/buildFromIterator_user_overrides/getMTime_errors.phpt
  M  ext/phar/tests/buildFromIterator_user_overrides/getPathname_exception.phpt
  M  ext/phar/tests/buildFromIterator_user_overrides/getPathname_wrong_type.phpt
  M  ext/phar/tests/create_new_phar_b.phpt
  M  ext/phar/tests/create_path_error.phpt
  M  ext/phar/tests/delete_in_phar.phpt
  M  ext/phar/tests/delete_in_phar_b.phpt
  M  ext/phar/tests/delete_in_phar_confirm.phpt
  M  ext/phar/tests/fgc_edgecases.phpt
  M  ext/phar/tests/fopen_edgecases.phpt
  M  ext/phar/tests/fopen_edgecases2.phpt
  M  ext/phar/tests/gh13833.phpt
  M  ext/phar/tests/gh14603.phpt
  M  ext/phar/tests/gh17518.phpt
  M  ext/phar/tests/gh19752.phpt
  M  ext/phar/tests/gh20302.phpt
  M  ext/phar/tests/gh20882.phpt
  M  ext/phar/tests/gh21798-offsetget-temp-entry.phpt
  M  ext/phar/tests/invalid_alias.phpt
  M  ext/phar/tests/invalid_setstubalias.phpt
  M  ext/phar/tests/invalid_string_phar_mungserver.phpt
  M  ext/phar/tests/mkdir.phpt
  M  ext/phar/tests/mounteddir.phpt
  M  ext/phar/tests/open_for_write_newfile_b.phpt
  M  ext/phar/tests/open_for_write_newfile_c.phpt
  M  ext/phar/tests/opendir_edgecases.phpt
  M  ext/phar/tests/phar_buildfromdirectory1.phpt
  M  ext/phar/tests/phar_buildfromdirectory2.phpt
  M  ext/phar/tests/phar_buildfromdirectory4.phpt
  M  ext/phar/tests/phar_buildfromdirectory5.phpt
  M  ext/phar/tests/phar_buildfromdirectory6.phpt
  M  ext/phar/tests/phar_buildfromiterator1.phpt
  M  ext/phar/tests/phar_buildfromiterator10.phpt
  M  ext/phar/tests/phar_buildfromiterator4.phpt
  M  ext/phar/tests/phar_buildfromiterator5.phpt
  M  ext/phar/tests/phar_buildfromiterator6.phpt
  M  ext/phar/tests/phar_buildfromiterator7.phpt
  M  ext/phar/tests/phar_buildfromiterator8.phpt
  M  ext/phar/tests/phar_buildfromiterator9.phpt
  M  ext/phar/tests/phar_bz2.phpt
  M  ext/phar/tests/phar_construct_invalidurl.phpt
  M  ext/phar/tests/phar_convert_again.phpt
  M  ext/phar/tests/phar_convert_metadata_leak.phpt
  M  ext/phar/tests/phar_convert_repeated_b.phpt
  M  ext/phar/tests/phar_create_in_cwd.phpt
  M  ext/phar/tests/phar_createdefaultstub.phpt
  M  ext/phar/tests/phar_decompress.phpt
  M  ext/phar/tests/phar_extract.phpt
  M  ext/phar/tests/phar_extract3.phpt
  M  ext/phar/tests/phar_magic_dir_prefix.phpt
  M  ext/phar/tests/phar_metadata_write4.phpt
  M  ext/phar/tests/phar_mount.phpt
  M  ext/phar/tests/phar_offset_check.phpt
  M  ext/phar/tests/phar_offset_get_error.phpt
  M  ext/phar/tests/phar_oo_001.phpt
  M  ext/phar/tests/phar_oo_006.phpt
  M  ext/phar/tests/phar_oo_011b.phpt
  M  ext/phar/tests/phar_oo_012b.phpt
  M  ext/phar/tests/phar_oo_compressallgz.phpt
  M  ext/phar/tests/phar_oo_getcontents.phpt
  M  ext/phar/tests/phar_setalias2.phpt
  M  ext/phar/tests/phar_setdefaultstub.phpt
  M  ext/phar/tests/phar_stub.phpt
  M  ext/phar/tests/phar_stub_error.phpt
  M  ext/phar/tests/phar_unlinkarchive.phpt
  M  ext/phar/tests/pharfileinfo_chmod.phpt
  M  ext/phar/tests/pharfileinfo_compression.phpt
  M  ext/phar/tests/pharfileinfo_construct.phpt
  M  ext/phar/tests/pharfileinfo_getcrc32.phpt
  M  ext/phar/tests/pharfileinfo_setmetadata.phpt
  M  ext/phar/tests/tar/033.phpt
  M  ext/phar/tests/tar/033a.phpt
  M  ext/phar/tests/tar/alias_acrobatics.phpt
  M  ext/phar/tests/tar/badalias.phpt
  M  ext/phar/tests/tar/badchecksum.phpt
  M  ext/phar/tests/tar/bignames.phpt
  M  ext/phar/tests/tar/bug71317-duplicate-filename.phpt
  M  ext/phar/tests/tar/bug71504.phpt
  M  ext/phar/tests/tar/create_new_phar_b.phpt
  M  ext/phar/tests/tar/delete_in_phar.phpt
  M  ext/phar/tests/tar/delete_in_phar_b.phpt
  M  ext/phar/tests/tar/delete_in_phar_confirm.phpt
  M  ext/phar/tests/tar/exists_as_phar.phpt
  M  ext/phar/tests/tar/links.phpt
  M  ext/phar/tests/tar/links2.phpt
  M  ext/phar/tests/tar/links3.phpt
  M  ext/phar/tests/tar/links4.phpt
  M  ext/phar/tests/tar/links5.phpt
  M  ext/phar/tests/tar/links6.phpt
  M  ext/phar/tests/tar/open_for_write_existing_b.phpt
  M  ext/phar/tests/tar/open_for_write_existing_c.phpt
  M  ext/phar/tests/tar/open_for_write_newfile_b.phpt
  M  ext/phar/tests/tar/open_for_write_newfile_c.phpt
  M  ext/phar/tests/tar/phar_buildfromiterator5.phpt
  M  ext/phar/tests/tar/phar_buildfromiterator6.phpt
  M  ext/phar/tests/tar/phar_buildfromiterator7.phpt
  M  ext/phar/tests/tar/phar_copy.phpt
  M  ext/phar/tests/tar/phar_setalias2.phpt
  M  ext/phar/tests/tar/phar_setdefaultstub.phpt
  M  ext/phar/tests/tar/phar_stub_error.phpt
  M  ext/phar/tests/tar/require_hash.phpt
  M  ext/phar/tests/tar/tar_001.phpt
  M  ext/phar/tests/tar/tar_002.phpt
  M  ext/phar/tests/tar/tar_003.phpt
  M  ext/phar/tests/tar/tar_nohash.phpt
  M  ext/phar/tests/tar/tar_nostub.phpt
  M  ext/phar/tests/tar/tar_openssl_hash.phpt
  M  ext/phar/tests/tar/truncated.phpt
  M  ext/phar/tests/test_alias_unset.phpt
  M  ext/phar/tests/test_unset.phpt
  M  ext/phar/tests/webphar_compilefail.phpt
  M  ext/phar/tests/zip/033.phpt
  M  ext/phar/tests/zip/033a.phpt
  M  ext/phar/tests/zip/alias_acrobatics.phpt
  M  ext/phar/tests/zip/badalias.phpt
  M  ext/phar/tests/zip/bzip2.phpt
  M  ext/phar/tests/zip/corrupt_001.phpt
  M  ext/phar/tests/zip/corrupt_002.phpt
  M  ext/phar/tests/zip/corrupt_003.phpt
  M  ext/phar/tests/zip/corrupt_004.phpt
  M  ext/phar/tests/zip/corrupt_005.phpt
  M  ext/phar/tests/zip/corrupt_006.phpt
  M  ext/phar/tests/zip/corrupt_007.phpt
  M  ext/phar/tests/zip/corrupt_008.phpt
  M  ext/phar/tests/zip/corrupt_009.phpt
  M  ext/phar/tests/zip/corrupt_010.phpt
  M  ext/phar/tests/zip/create_new_phar_b.phpt
  M  ext/phar/tests/zip/delete_in_phar.phpt
  M  ext/phar/tests/zip/delete_in_phar_b.phpt
  M  ext/phar/tests/zip/delete_in_phar_confirm.phpt
  M  ext/phar/tests/zip/exists_as_phar.phpt
  M  ext/phar/tests/zip/getalias.phpt
  M  ext/phar/tests/zip/odt.phpt
  M  ext/phar/tests/zip/open_for_write_newfile_b.phpt
  M  ext/phar/tests/zip/open_for_write_newfile_c.phpt
  M  ext/phar/tests/zip/phar_buildfromiterator5.phpt
  M  ext/phar/tests/zip/phar_buildfromiterator6.phpt
  M  ext/phar/tests/zip/phar_buildfromiterator7.phpt
  M  ext/phar/tests/zip/phar_copy.phpt
  M  ext/phar/tests/zip/phar_setalias2.phpt
  M  ext/phar/tests/zip/phar_setdefaultstub.phpt
  M  ext/phar/tests/zip/phar_stub_error.phpt
  M  ext/phar/tests/zip/require_hash.phpt
  M  ext/phar/tests/zip/zip_extra_underflow.phpt
  M  ext/phar/tests/zip/zlib.phpt


Diff exceeded maximum size.