[PHP-CVS] [php-src] master: ext/readline: Fix flacky readline CLI pager test

[email protected] (Weilin Du) Tue, 4 Aug 2026 17:30:47 +0000
Newsgroups php.cvs
Message-ID <[email protected]>
Author: Weilin Du (LamentXU123)
Date: 2026-08-05T01:30:28+08:00

Commit: https://github.com/php/php-src/commit/34a294993d8cc4fa382ffc90f44e90f3cb74d44d
Raw diff: https://github.com/php/php-src/commit/34a294993d8cc4fa382ffc90f44e90f3cb74d44d.diff

ext/readline: Fix flacky readline CLI pager test

This fix the ext/readline/tests/readline_cli_pager.phpt test
introduced in GH-22994.

Changed paths:
  M  ext/readline/readline_cli.c


Diff:

diff --git a/ext/readline/readline_cli.c b/ext/readline/readline_cli.c
index 3b2a08a15843..4ffe4dfff0e0 100644
--- a/ext/readline/readline_cli.c
+++ b/ext/readline/readline_cli.c
@@ -710,7 +710,7 @@ static int readline_shell_run(void) /* {{{ */
 		}
 
 		if (pager_pipe) {
-			fclose(pager_pipe);
+			pclose(pager_pipe);
 			pager_pipe = NULL;
 		}