[PHP-CVS] [php-src] PHP-8.5: Fix JUnit timing aggregation for long-running tests (#23438)

[email protected] (Levi Morrison)
Newsgroups php.cvs
Message-ID <[email protected]>
Author: Levi Morrison (morrisonlevi)
Date: 2026-08-24T10:22:50-06:00

Commit: https://github.com/php/php-src/commit/7c0390b81548ec71ce7f481505be82443d1f12d9
Raw diff: https://github.com/php/php-src/commit/7c0390b81548ec71ce7f481505be82443d1f12d9.diff

Fix JUnit timing aggregation for long-running tests (#23438)

Changed paths:
  M  run-tests.php


Diff:

diff --git a/run-tests.php b/run-tests.php
index e4a4563f93fc..dfb07a465bd5 100755
--- a/run-tests.php
+++ b/run-tests.php
@@ -3386,6 +3386,7 @@ public function markTestAs(
 
         $time = $time ?? $this->getTimer($file_name);
         $this->record($suite, 'execution_time', $time);
+        $formatted_time = number_format($time, 4, '.', '');
 
         $escaped_details = htmlspecialchars($details, ENT_QUOTES, 'UTF-8');
         $escaped_details = preg_replace_callback('/[\0-\x08\x0B\x0C\x0E-\x1F]/', function ($c) {
@@ -3394,7 +3395,7 @@ public function markTestAs(
         $escaped_message = htmlspecialchars($message, ENT_QUOTES, 'UTF-8');
 
         $escaped_test_name = htmlspecialchars($file_name . ' (' . $test_name . ')', ENT_QUOTES);
-        $this->rootSuite['files'][$file_name]['xml'] = "<testcase name='$escaped_test_name' time='$time'>\n";
+        $this->rootSuite['files'][$file_name]['xml'] = "<testcase name='$escaped_test_name' time='$formatted_time'>\n";
 
         if (is_array($type)) {
             $output_type = $type[0] . 'ED';
@@ -3439,7 +3440,7 @@ private function getTimer(string $file_name)
         }
 
         if (isset($this->rootSuite['files'][$file_name]['total'])) {
-            return number_format($this->rootSuite['files'][$file_name]['total'], 4);
+            return $this->rootSuite['files'][$file_name]['total'];
         }
 
         return 0;
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.