Re: [PHP-DEV] [PATCH] - fix for 64 bit issues with OnUpdateInt

[email protected] (Andi Gutmans)
Newsgroups php.dev
Message-ID <[email protected]>
At 11:03 PM 3/4/2003 +0100, Sascha Schumann wrote:
>On Tue, 4 Mar 2003, Jani Taskinen wrote:
>
> >
> >     Yup, that was the idea. I'll first change them
> >     all to OnUpdateInteger, and then use your patch
> >     to change the ones that need to be long to use OnUpdateLong.
>
>     Is there any specific reason why a single API (OnUpdateLong)
>     is not sufficient?  Is not it a safe assumption that those
>     modules which still use 'int's are simply the result of a
>     mistake on the developer's side?

A single API is probably sufficient but I can understand that extension 
writers might want to use ints. The INI flag might have nothing to do with 
an internal zval and an int might be more than enough.
I don't really mind but I wouldn't introduce OnUpdateInteger.
I guess we should either move everything to OnUpdateLong() and nuke 
OnUpdateInt() in ZE2 or we change OnUpdateInt to work with ints and fix the 
whole code.
It might be less confusing to just have one.
Andi
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.