Re: [PHP-DEV] 64bit PHP on solaris

[email protected] (Wez Furlong) Sat, 15 Mar 2003 13:14:37 +0000 (GMT)
Newsgroups php.dev
Message-ID <[email protected]>
On Sat, 15 Mar 2003, James Devenish wrote:
> Regardless of what you personally understand (and what I personally
> understand), my point would be that the problems are simply unfixed
> by *anyone*.

This is the first time that anyone has brought this issue to my
attention.

> Index: main/streams.c
> ===================================================================
> RCS file: /repository/php4/main/Attic/streams.c,v
> retrieving revision 1.125.2.37
> diff -u -u -r1.125.2.37 streams.c
> --- main/streams.c	6 Mar 2003 20:58:19 -0000	1.125.2.37
> +++ main/streams.c	8 Mar 2003 10:48:16 -0000
> @@ -1532,7 +1532,7 @@
>  			}
>  			if (ret) {
>  				fflush(data->file);
> -				*ret = (void*)fd;
> +				*(int*)ret = fd;
>  			}
>  			return SUCCESS;
>  		default:

> What have I done? Well, someone's taking fd (declared as an 'int', which
> ...

There is no need for a patronizing tone here; I can read C code.

I will commit this fix shortly.  Are there any other places in the
streams code that are similarly affected?

--Wez.