Doc #71916 [Ver->Csd]: Two attribute constants use the same value

Edit report at https://bugs.php.net/bug.php?id=71916&edit=1

 ID:                 71916
 Updated by:         [email protected]
 Reported by:        downsider84 at hotmail dot com
 Summary:            Two attribute constants use the same value
-Status:             Verified
+Status:             Closed
 Type:               Documentation Problem
 Package:            PDO related
 Operating System:   Irrelevant
 PHP Version:        7.0.4
 Block user comment: N
 Private report:     N

 New Comment:

Automatic comment on behalf of cmb69
Revision: https://github.com/php/doc-en/commit/af64507ffdd4fe88b2dc19efade2cf6230cde739
Log: Fix #71916: Two attribute constants use the same value


Previous Comments:
------------------------------------------------------------------------
[2020-04-07 11:18:24] [email protected]

Indeed, doc issue.

------------------------------------------------------------------------
[2016-03-29 13:06:37] downsider84 at hotmail dot com

I'm not sure there will be a solution, given the policy of starting driver specific constants at 1000 (I can't think of anything comprehensive), so that only leaves us with documenting the issue

After bit of digging, it looks like if a driver implements custom attributes then it has some disclaimer boilerplate saying not to use the constants with other drivers. However, this is tucked away inside the docs for each driver.
Perhaps we should add something to the docs for getAttribute and setAttribute to make the convention more visible?

------------------------------------------------------------------------
[2016-03-29 12:18:16] [email protected]

This seems to be a flaw in the design of PDO; Drivers with driver specific attributes are instructed to use the same value "PDO_ATTR_DRIVER_SPECIFIC" (1000) to identify their first specific attribute. 

Any two drivers with driver specific attributes are vulnerable to the same problem.

I am not super familiar with PDO, so, unsure how to fix it ...

------------------------------------------------------------------------
[2016-03-29 11:34:01] downsider84 at hotmail dot com

Description:
------------
The constants MYSQL_ATTR_USE_BUFFERED_QUERY and PGSQL_ATTR_DISABLE_NATIVE_PREPARED_STATEMENT have the same value, 1000.

Setting MYSQL_ATTR_USE_BUFFERED_QUERY when using the pgsql driver causes a "deprecated" warning about PGSQL_ATTR_DISABLE_NATIVE_PREPARED_STATEMENT. This is non-obvious and potentially difficult to debug.

Test script:
---------------
ini_set("display_errors", 1);
error_reporting(E_ALL);

// change credentials as appropriate
$dbName = "test";
$host = "locahost";
$username = "root";
$password = "";

$pdo = new \PDO("pgsql:$dbName=db;host=$host", $username, $password);
$pdo->setAttribute(\PDO:MYSQL_ATTR_USE_BUFFERED_QUERY, true);

Expected result:
----------------
Deprecated:  PDO::setAttribute(): PDO::PGSQL_ATTR_DISABLE_NATIVE_PREPARED_STATEMENT is deprecated, use PDO::ATTR_EMULATE_PREPARES instead in [filename] on line [lineno]



------------------------------------------------------------------------



--
Edit this bug report at https://bugs.php.net/bug.php?id=71916&edit=1