[DOC-CVS] [doc-base] check-ci-without-jing: fix: use strict equality check for return code validation
[email protected] (Jordi Kroon) Fri, 24 Jul 2026 14:01:50 +0000
| Newsgroups | php.doc.cvs |
|---|---|
| Message-ID | <[email protected]> |
Author: Jordi Kroon (jordikroon)
Date: 2026-07-24T16:01:45+02:00
Commit: https://github.com/php/doc-base/commit/7a0c87ca9bfa60269bc46c2706b1775fe5542f75
Raw diff: https://github.com/php/doc-base/commit/7a0c87ca9bfa60269bc46c2706b1775fe5542f75.diff
fix: use strict equality check for return code validation
Changed the condition from `!$ret` to `$ret === 0` to properly validate the return code. This uses strict equality to explicitly check if the return code is 0 (success), making the intent clearer and avoiding potential issues with truthy/falsy value coercion.
Changed paths:
M configure.php
Diff:
diff --git a/configure.php b/configure.php
index fe7f54042d..91d7ad3156 100755
--- a/configure.php
+++ b/configure.php
@@ -1028,7 +1028,7 @@ function xml_validate_jing()
if ( ! is_array( $out ) )
$out = [];
- if ( !$ret )
+ if ( $ret === 0 )
{
echo "done.\n";
return;