svn: /web/doc-editor/trunk/js/ui/task/ AcceptPatchTask.js CheckFileTask.js ClearLocalChangeTask.js GetFileTask.js LoadConfigTask.js MarkDeleteTask.js PingTask.js RejectPatchTask.js SaveENFileTask.js SaveLangFileTask.js SavePatchTask.js SystemUpdateTask.js UpdateConfTask.js VCSCommitTask.js
[email protected] (Yannick Torres)
| Newsgroups | php.doc.web |
|---|---|
| Message-ID | <[email protected]> |
yannick Sat, 24 Oct 2009 09:04:41 +0000
Revision: http://svn.php.net/viewvc?view=revision&revision=289899
Log:
exec jsLint on ui/task
Changed paths:
U web/doc-editor/trunk/js/ui/task/AcceptPatchTask.js
U web/doc-editor/trunk/js/ui/task/CheckFileTask.js
U web/doc-editor/trunk/js/ui/task/ClearLocalChangeTask.js
U web/doc-editor/trunk/js/ui/task/GetFileTask.js
U web/doc-editor/trunk/js/ui/task/LoadConfigTask.js
U web/doc-editor/trunk/js/ui/task/MarkDeleteTask.js
U web/doc-editor/trunk/js/ui/task/PingTask.js
U web/doc-editor/trunk/js/ui/task/RejectPatchTask.js
U web/doc-editor/trunk/js/ui/task/SaveENFileTask.js
U web/doc-editor/trunk/js/ui/task/SaveLangFileTask.js
U web/doc-editor/trunk/js/ui/task/SavePatchTask.js
U web/doc-editor/trunk/js/ui/task/SystemUpdateTask.js
U web/doc-editor/trunk/js/ui/task/UpdateConfTask.js
U web/doc-editor/trunk/js/ui/task/VCSCommitTask.js
svn-diffs-289899.txt
(text/x-diff, 14.2 KB)
Modified: web/doc-editor/trunk/js/ui/task/AcceptPatchTask.js
===================================================================
--- web/doc-editor/trunk/js/ui/task/AcceptPatchTask.js 2009-10-23 23:26:10 UTC (rev 289898)
+++ web/doc-editor/trunk/js/ui/task/AcceptPatchTask.js 2009-10-24 09:04:41 UTC (rev 289899)
@@ -76,7 +76,4 @@
} // btn = yes
}, this // scope
);
-}
-
-
-
+};
\ No newline at end of file
Modified: web/doc-editor/trunk/js/ui/task/CheckFileTask.js
===================================================================
--- web/doc-editor/trunk/js/ui/task/CheckFileTask.js 2009-10-23 23:26:10 UTC (rev 289898)
+++ web/doc-editor/trunk/js/ui/task/CheckFileTask.js 2009-10-24 09:04:41 UTC (rev 289899)
@@ -29,7 +29,7 @@
{
Ext.getBody().unmask();
- var o = Ext.util.JSON.decode(response.responseText);
+ var o = Ext.util.JSON.decode(response.responseText), tmp;
// If there is some errors, we display this
if (o.error && o.error_first !== '-No error-') {
@@ -57,7 +57,7 @@
}
// Now, We save LANG File
- new ui.task.SaveLangFileTask({
+ tmp = new ui.task.SaveLangFileTask({
prefix : this.prefix,
ftype : this.ftype,
fid : this.fid,
@@ -79,4 +79,4 @@
ui.component.ErrorFileGrid.getInstance().store.reload();
}
});
-}
+};
Modified: web/doc-editor/trunk/js/ui/task/ClearLocalChangeTask.js
===================================================================
--- web/doc-editor/trunk/js/ui/task/ClearLocalChangeTask.js 2009-10-23 23:26:10 UTC (rev 289898)
+++ web/doc-editor/trunk/js/ui/task/ClearLocalChangeTask.js 2009-10-24 09:04:41 UTC (rev 289899)
@@ -59,9 +59,7 @@
ui.component.NotInENGrid.getInstance().store.each(
function(record)
{
- if ((phpDoc.userLang+record.data.path) === this.fpath
- && record.data.name === this.fname
- ) {
+ if ((phpDoc.userLang+record.data.path) === this.fpath && record.data.name === this.fname ) {
record.set('needcommit', false);
}
},
@@ -72,9 +70,7 @@
ui.component.PendingReviewGrid.getInstance().store.each(
function(record)
{
- if ((phpDoc.userLang+record.data.path) === this.fpath
- && record.data.name === this.fname
- ) {
+ if ((phpDoc.userLang+record.data.path) === this.fpath && record.data.name === this.fname ) {
record.set('needcommit', false);
}
},
@@ -85,9 +81,7 @@
ui.component.StaleFileGrid.getInstance().store.each(
function(record)
{
- if ((phpDoc.userLang+record.data.path) === this.fpath
- && record.data.name === this.fname
- ) {
+ if ((phpDoc.userLang+record.data.path) === this.fpath && record.data.name === this.fname ) {
record.set('needcommit', false);
}
},
@@ -98,9 +92,7 @@
ui.component.ErrorFileGrid.getInstance().store.each(
function(record)
{
- if ((phpDoc.userLang+record.data.path) === this.fpath
- && record.data.name === this.fname
- ) {
+ if ((phpDoc.userLang+record.data.path) === this.fpath && record.data.name === this.fname ) {
record.set('needcommit', false);
}
},
@@ -124,4 +116,4 @@
}
}, this
);
-}
+};
Modified: web/doc-editor/trunk/js/ui/task/GetFileTask.js
===================================================================
--- web/doc-editor/trunk/js/ui/task/GetFileTask.js 2009-10-23 23:26:10 UTC (rev 289898)
+++ web/doc-editor/trunk/js/ui/task/GetFileTask.js 2009-10-24 09:04:41 UTC (rev 289899)
@@ -44,4 +44,4 @@
}
}
});
-}
+};
Modified: web/doc-editor/trunk/js/ui/task/LoadConfigTask.js
===================================================================
--- web/doc-editor/trunk/js/ui/task/LoadConfigTask.js 2009-10-23 23:26:10 UTC (rev 289898)
+++ web/doc-editor/trunk/js/ui/task/LoadConfigTask.js 2009-10-24 09:04:41 UTC (rev 289899)
@@ -37,4 +37,4 @@
phpDoc.drawInterface();
}
});
-}
+};
Modified: web/doc-editor/trunk/js/ui/task/MarkDeleteTask.js
===================================================================
--- web/doc-editor/trunk/js/ui/task/MarkDeleteTask.js 2009-10-23 23:26:10 UTC (rev 289898)
+++ web/doc-editor/trunk/js/ui/task/MarkDeleteTask.js 2009-10-24 09:04:41 UTC (rev 289899)
@@ -37,4 +37,4 @@
}
}, this
);
-}
+};
Modified: web/doc-editor/trunk/js/ui/task/PingTask.js
===================================================================
--- web/doc-editor/trunk/js/ui/task/PingTask.js 2009-10-23 23:26:10 UTC (rev 289898)
+++ web/doc-editor/trunk/js/ui/task/PingTask.js 2009-10-24 09:04:41 UTC (rev 289899)
@@ -30,7 +30,7 @@
});
this.task.delay(30000);
}, this);
-}
+};
// delegates
ui.task.PingTask.prototype.delay = function(delay, newFn, newScope, newArgs)
@@ -50,4 +50,4 @@
ui.task._PingTask.instance = new ui.task.PingTask();
}
return ui.task._PingTask.instance;
-}
+};
Modified: web/doc-editor/trunk/js/ui/task/RejectPatchTask.js
===================================================================
--- web/doc-editor/trunk/js/ui/task/RejectPatchTask.js 2009-10-23 23:26:10 UTC (rev 289898)
+++ web/doc-editor/trunk/js/ui/task/RejectPatchTask.js 2009-10-24 09:04:41 UTC (rev 289899)
@@ -48,4 +48,4 @@
} // btn = yes
}, this // scope
);
-}
+};
Modified: web/doc-editor/trunk/js/ui/task/SaveENFileTask.js
===================================================================
--- web/doc-editor/trunk/js/ui/task/SaveENFileTask.js 2009-10-23 23:26:10 UTC (rev 289898)
+++ web/doc-editor/trunk/js/ui/task/SaveENFileTask.js 2009-10-24 09:04:41 UTC (rev 289899)
@@ -76,4 +76,4 @@
phpDoc.winForbidden();
}
});
-}
+};
Modified: web/doc-editor/trunk/js/ui/task/SaveLangFileTask.js
===================================================================
--- web/doc-editor/trunk/js/ui/task/SaveLangFileTask.js 2009-10-23 23:26:10 UTC (rev 289898)
+++ web/doc-editor/trunk/js/ui/task/SaveLangFileTask.js 2009-10-24 09:04:41 UTC (rev 289899)
@@ -82,4 +82,4 @@
phpDoc.winForbidden();
}
});
-}
+};
Modified: web/doc-editor/trunk/js/ui/task/SavePatchTask.js
===================================================================
--- web/doc-editor/trunk/js/ui/task/SavePatchTask.js 2009-10-23 23:26:10 UTC (rev 289898)
+++ web/doc-editor/trunk/js/ui/task/SavePatchTask.js 2009-10-24 09:04:41 UTC (rev 289899)
@@ -14,10 +14,7 @@
Ext.getCmp(id_prefix + '-PANEL-' + this.fid).originTitle
);
- if ( (this.prefix === 'AF')
- || (this.lang === 'en' && Ext.getCmp(this.prefix+'-LANG-FILE-'+this.fid).isModified === false)
- || (this.lang !== 'en' && Ext.getCmp(this.prefix+'-EN-FILE-'+this.fid).isModified === false)
- ) {
+ if ( (this.prefix === 'AF') || (this.lang === 'en' && Ext.getCmp(this.prefix+'-LANG-FILE-'+this.fid).isModified === false) || (this.lang !== 'en' && Ext.getCmp(this.prefix+'-EN-FILE-'+this.fid).isModified === false) ) {
Ext.getCmp(this.prefix + '-' + this.fid).setTitle(
Ext.getCmp(this.prefix + '-' + this.fid).originTitle
);
@@ -56,4 +53,4 @@
msg.hide();
}
});
-}
+};
Modified: web/doc-editor/trunk/js/ui/task/SystemUpdateTask.js
===================================================================
--- web/doc-editor/trunk/js/ui/task/SystemUpdateTask.js 2009-10-23 23:26:10 UTC (rev 289898)
+++ web/doc-editor/trunk/js/ui/task/SystemUpdateTask.js 2009-10-24 09:04:41 UTC (rev 289899)
@@ -27,7 +27,7 @@
// Re-enable win's close button
Ext.getCmp('sys-update-win').tools.close.setVisible(true);
-}
+};
ui.task._SystemUpdateTask.poll_apply_tool = new Ext.util.DelayedTask(function()
{
@@ -42,10 +42,10 @@
},
failure : function(response)
{
- var o = Ext.util.JSON.decode(response.responseText);
+ var o = Ext.util.JSON.decode(response.responseText), tmp;
if (o && o.success === false) {
Ext.get('wizard-step-2').replaceClass('wizard-step-working', 'wizard-step-done');
- new ui.task._SystemUpdateTask.refresh_ui();
+ tmp = new ui.task._SystemUpdateTask.refresh_ui();
} else {
ui.task._SystemUpdateTask.poll_apply_tool.delay(5000);
}
@@ -60,15 +60,16 @@
params : { task: 'applyTools' },
success : function(response)
{
+ var tmp;
Ext.get('wizard-step-2').replaceClass('wizard-step-working', 'wizard-step-done');
- new ui.task._SystemUpdateTask.refresh_ui();
+ tmp = new ui.task._SystemUpdateTask.refresh_ui();
},
failure : function(response)
{
ui.task._SystemUpdateTask.poll_apply_tool.delay(5000);
}
});
-}
+};
ui.task._SystemUpdateTask.vcs_poll = new Ext.util.DelayedTask(function()
{
@@ -83,13 +84,13 @@
},
failure : function(response)
{
- var o = Ext.util.JSON.decode(response.responseText);
+ var o = Ext.util.JSON.decode(response.responseText), tmp;
if (o && o.success === false) {
Ext.get('wizard-step-1').replaceClass('wizard-step-working', 'wizard-step-done');
Ext.get('wizard-step-1.1').replaceClass('wizard-show', 'wizard-wait');
- new ui.task._SystemUpdateTask.apply_tool();
+ tmp = new ui.task._SystemUpdateTask.apply_tool();
} else {
ui.task._SystemUpdateTask.vcs_poll.delay(5000);
}
@@ -108,10 +109,12 @@
params : { task: 'updateRepository' },
success : function(response)
{
+ var tmp;
+
Ext.get('wizard-step-1').replaceClass('wizard-step-working', 'wizard-step-done');
Ext.get('wizard-step-1.1').replaceClass('wizard-show', 'wizard-wait');
- new ui.task._SystemUpdateTask.apply_tool();
+ tmp = new ui.task._SystemUpdateTask.apply_tool();
},
failure: function(response)
{
@@ -125,4 +128,4 @@
}
}
});
-}
+};
Modified: web/doc-editor/trunk/js/ui/task/UpdateConfTask.js
===================================================================
--- web/doc-editor/trunk/js/ui/task/UpdateConfTask.js 2009-10-23 23:26:10 UTC (rev 289898)
+++ web/doc-editor/trunk/js/ui/task/UpdateConfTask.js 2009-10-24 09:04:41 UTC (rev 289899)
@@ -57,4 +57,4 @@
}
}
});
-}
+};
Modified: web/doc-editor/trunk/js/ui/task/VCSCommitTask.js
===================================================================
--- web/doc-editor/trunk/js/ui/task/VCSCommitTask.js 2009-10-23 23:26:10 UTC (rev 289898)
+++ web/doc-editor/trunk/js/ui/task/VCSCommitTask.js 2009-10-24 09:04:41 UTC (rev 289899)
@@ -30,12 +30,12 @@
},
success : function(response)
{
- var o = Ext.util.JSON.decode(response.responseText);
+ var o = Ext.util.JSON.decode(response.responseText), tmp;
Ext.getBody().unmask();
// Display commit output message
- new Ext.Window({
+ tmp = new Ext.Window({
title : _('Status'),
width : 450,
height : 350,
@@ -82,7 +82,7 @@
});
}
});
-}
+};
ui.task.VCSCommitTask = function()
{
@@ -95,7 +95,7 @@
}
var files = Ext.getCmp('commit-tree-panel').getValue(),
- NeedToBeClose = new Array(),
+ NeedToBeClose = [],
checkNode, paneID_FE, paneID_FNU, paneID_FNR, paneID, labelNeedToBeClose = '';
for (var i = 0; i < files.length; ++i) {
@@ -105,10 +105,7 @@
paneID_FNU = 'FNU-' + Ext.util.md5('FNU-' + checkNode.FilePath + checkNode.FileName);
paneID_FNR = 'FNR-' + Ext.util.md5('FNR-' + checkNode.FilePath + checkNode.FileName);
- if ( Ext.getCmp('main-panel').findById(paneID_FE)
- || Ext.getCmp('main-panel').findById(paneID_FNU)
- || Ext.getCmp('main-panel').findById(paneID_FNR)
- ) {
+ if ( Ext.getCmp('main-panel').findById(paneID_FE) || Ext.getCmp('main-panel').findById(paneID_FNU) || Ext.getCmp('main-panel').findById(paneID_FNR) ) {
if (Ext.getCmp('main-panel').findById(paneID_FE)) {
paneID = paneID_FE;
}
@@ -124,16 +121,15 @@
}
if (NeedToBeClose.length > 0) {
- for (var i = 0; i < NeedToBeClose.length; ++i) {
- labelNeedToBeClose += NeedToBeClose[i][1] + '<br/>';
+ for (var j = 0; j < NeedToBeClose.length; ++j) {
+ labelNeedToBeClose += NeedToBeClose[j][1] + '<br/>';
}
Ext.MessageBox.show({
title : 'Warning',
icon : Ext.MessageBox.INFO,
buttons : Ext.MessageBox.YESNOCANCEL,
- msg : (NeedToBeClose.length > 1)
- ? String.format(
+ msg : (NeedToBeClose.length > 1) ? String.format(
_('There is {0} files to close before commit.<br><br>' +
'{1}<br/><br/>Would you like I close it for you ?'),
NeedToBeClose.length, labelNeedToBeClose)
@@ -155,4 +151,4 @@
} else {
ui.task._VCSCommitTask.commit(files);
}
-}
+};