Re: [DOC-WEB] com web/doc: Advertise https://github.com/php/doc-en/pulls: tutorial/joining.md

--000000000000460606058fb38540
Content-Type: text/plain; charset="UTF-8"

On Fri, 9 Aug 2019 at 19:33, Christoph M. Becker <[email protected]> wrote:

> On 09.08.2019 at 20:17, Peter Cowburn wrote:
>
> > On Fri, 9 Aug 2019 at 17:01, Christoph M. Becker <[email protected]>
> wrote:
> >
> >> On 09.08.2019 at 17:52, Peter Cowburn wrote:
> >>
> >>> On Fri, 9 Aug 2019 at 16:43, Christoph Michael Becker <[email protected]>
> >> wrote:
> >>>
> >>>> Commit:    1275db0052fa627ed0c4896c6e6120f3cd9c1ec0
> >>>> Author:    Christoph M. Becker <[email protected]>         Fri, 9 Aug
> >>>> 2019 17:43:35 +0200
> >>>> Parents:   61e52a420433d3d0cd4502c6b7c833cc37ea532b
> >>>> Branches:  master
> >>>>
> >>>> Link:
> >>>>
> >>
> http://git.php.net/?p=web/doc.git;a=commitdiff;h=1275db0052fa627ed0c4896c6e6120f3cd9c1ec0
> >>>>
> >>>> Log:
> >>>> Advertise https://github.com/php/doc-en/pulls
> >>>>
> >>>> Changed paths:
> >>>>   M  tutorial/joining.md
> >>>>
> >>>>
> >>>> Diff:
> >>>> diff --git a/tutorial/joining.md b/tutorial/joining.md
> >>>> index 1555eed..744c46d 100644
> >>>> --- a/tutorial/joining.md
> >>>> +++ b/tutorial/joining.md
> >>>> @@ -22,6 +22,8 @@ The simplest way to get started is by using the
> >> [Online
> >>>> Documentation Editor][ed
> >>>>  which allows you to login via your Facebook/Twitter/Google account
> and
> >>>> edit the documentation.
> >>>>  Your patches will be then reviewed and accepted by someone with SVN
> >>>> access.
> >>>>
> >>>> +The preferred way to submit documentation patches are [pull
> requests](
> >>>> https://github.com/php/doc-en/pulls) (only English for now).
> >>>> +
> >>>>
> >>>
> >>> This is not true, yet. The Git(Hub) integration is very experimental
> and
> >>> not recommended for public use at this time.
> >>
> >> This is about pull requests, and IMO it's better to have people submit
> >> PRs to the experimental interface instead of submitting patches to
> >> edit.php.net, where nobody looks after them, despite the paragraphs
> >> saying "Your patches will be then reviewed and accepted by someone with
> >> SVN access".
> >>
> >
> > I understand, and have no objection to mentioning *experimentally* being
> > able to submit PRs on GitHub for the English docs, but it's still not
> > *the* *preferred
> > way* right now.
> > Please wait until the infrastructure and supporting systems are all in
> > place before making statements like that.
>
> Okay, I get your point.  I have reverted the commit, and also the

respective commit for web/php.
>

Okay.  I look forward to the day when we *can* start sending folks in the
direction of creating pull requests.  :)


> Thanks,
> Christoph
>
> > P.S. This paragraph should be moved lower down, it's in the middle of
> > paragraphs about the editor right now.
> >
> >
> >>
> >>>>  Our wiki contains an [overview of the editor and how to use
> >>>> it][editor-tutorial].
> >>>>
> >>>>  ## Obtaining SVN access
> >>>>
> >>>>
> >>>> --
> >>>> Documentation Website Mailing List (http://doc.php.net/)
> >>>> To unsubscribe, visit: http://www.php.net/unsub.php
> >>>>
> >>>>
> >>>
> >>
> >> --
> >> Documentation Website Mailing List (http://doc.php.net/)
> >> To unsubscribe, visit: http://www.php.net/unsub.php
> >>
> >>
> >
>

--000000000000460606058fb38540--