Re: Add commit ID to build info
[email protected] ("Adiel Cristo via phpdoc")
| Newsgroups | php.doc |
|---|---|
| Message-ID | <CAD2BokRfJ1wa3o55Td_WKOQEYhm9t3j3sYcUMORgXnuSjMkFHw@mail.gmail.com> |
Thanks, Christoph. PR submitted. Best regards, *Adiel Cristo* Senior PHP Developer [email protected] LinkedIn <http://br.linkedin.com/in/adielcristo> On Mon, Feb 1, 2021 at 9:17 AM Christoph M. Becker <[email protected]> wrote: > On 29.01.2021 at 01:25, Adiel Cristo via phpdoc wrote: > > > I fixed the pt_br doc build, but for some reason the changes did not > > seem to work (or even to be applied) on the remote server. > > > > I added some changes on the doc/base/configure.php file to get the > > commit ID (patch attached), but I'm not sure if I have permissions to, > > or if I should change this file. > > > > Any thoughts? > > I'm not sure about the usefulness of this patch, but maybe consider to > submit that as PR to <https://github.com/php/doc-base>. > > Regards, > Christoph > >