Re: Re[4]: How to manage github pull requests?

On Tue, 2 Feb 2021 at 19:10, Sergey Panteleev <[email protected]> wrote:

> Hi George,
>
> Thank you for your hard work!
>
> Hmm... Can you check the script?
> After the commit "Update EN-Revision tags for new rev-check" [1], I got
> many diffs in my checker =(
>
> For example,
>
> English file [2] has last git id 4754397753fd79f1c846868b66a2448babab1c54,
> but this commit sets the id e9366ee458b2900c53a503b1ad97664e1d9a8859.
>
> The previous id was right [3].
>
> [1]
> https://github.com/php/doc-ru/commit/f192aaffda43055842db90fb5e1a478c44cdbfa9
> [2]
> https://github.com/php/doc-en/blob/master/reference/apcu/apcuiterator/key.xml
> [3]
> https://github.com/php/doc-ru/blob/3d6dff193c2bda6d1057b7392d343e9c14bbbe05/reference/apcu/apcuiterator/key.xml
>
> Or maybe I'm doing something wrong :)
>
> wbr,
> Sergey Panteleev
>

Nothing wrong with your logic, it's just that in my script I "removed" the
following three commits
// XML Formatting commits
'8d666e819852f6b0561b40fcf8689b747568865c',
// vrana's mass commit
'69bd53265b6c8cf0ba4135142488de6dcb78e4eb',
// the revert commit
'4754397753fd79f1c846868b66a2448babab1c54',

As one was immediatly reverted, and another one was an XML formatting
commit, as the revert didn't make any changes and was showing about 5000
files being outaded for the French translation.
Because I hadn't set-up something to automatically patch empty diffs
between revisions to have a more accurate picture of the actual state I
decided to throw away those commits.
This is maybe less necessary now that at each rev-check a diff patch is
created.

Let me know if I should drop these ignored commits and re-run the diffs to
fix it again. :-)

Best,

George P. Banyard