Re: Add commit ID to build info

By the way, which are the requirements to have access
to the doc server?

Best regards,
*Adiel Cristo*
Senior PHP Developer
[email protected]
LinkedIn <http://br.linkedin.com/in/adielcristo>


On Tue, Feb 2, 2021 at 3:16 PM Adiel Cristo <[email protected]> wrote:

> Thanks, Andreas, Christoph.
>
> Best regards,
> *Adiel Cristo*
> Senior PHP Developer
> [email protected]
> LinkedIn <http://br.linkedin.com/in/adielcristo>
>
>
> On Tue, Feb 2, 2021 at 12:12 PM Christoph M. Becker <[email protected]>
> wrote:
>
>> On 02.02.2021 at 07:25, Andreas Heigl wrote:
>>
>> > Hey Folks
>> >
>> > Am 01.02.21 um 23:27 schrieb Christoph M. Becker:
>> >> On 01.02.2021 at 15:59, André L F S Bacci wrote:
>> >>
>> >>> On Mon, Feb 1, 2021 at 12:17 PM Christoph M. Becker <
>> [email protected]>
>> >>> wrote:
>> >>>
>> >>>> On 29.01.2021 at 01:25, Adiel Cristo via phpdoc wrote:
>> >>>>
>> >>>>> I fixed the pt_br doc build, but for some reason the changes did not
>> >>>>> seem to work (or even to be applied) on the remote server.
>> >>>>>
>> >>>>> I added some changes on the doc/base/configure.php file to get the
>> >>>>> commit ID (patch attached), but I'm not sure if I have permissions
>> to,
>> >>>>> or if I should change this file.
>> >>>>>
>> >>>>> Any thoughts?
>> >>>>
>> >>>> I'm not sure about the usefulness of this patch, but maybe consider
>> to
>> >>>> submit that as PR to <https://github.com/php/doc-base>.
>> >>>>
>> >>>
>> >>> It's about trying to find why pt_BR is not building, or at least why
>> it's
>> >>> giving an error that does not occur in a local build.
>> >>>
>> >>> I may suggest another, more general approach. To make the VCS output
>> to be
>> >>> added in logs of http://doc.php.net/logs/ . Or at least to add the
>> output
>> >>> of `git status` and `git log -1` when an error occurs (or even
>> better, to
>> >>> add these lines before doc-base/configure).
>> >>>
>> >>> I really think all three above would be a very comprehensive solution
>> for
>> >>> debugging building problems.
>> >>
>> >> In this case the build error[1] is about something that had already
>> been
>> >> removed 5 days ago in pt_BR[2].  So apparently, the doc builder uses an
>> >> old revision, for some reason.  I think somebody with access to the doc
>> >> builder machine needs to look at this.
>> >
>> > Looks like I found the culprit. Again the case-differences between the
>> > language name pt_BR and the folder-name pt_br.
>> >
>> > I've already created a PR to fix that[1] as well as fixed it in the
>> > live-system. So the next run of the doc-build at 8:00 UTC should include
>> > the changes you are waiting for. And from then on it should run without
>> > issues. I'll nevertheless check the results.
>> >
>> > [1] https://github.com/php/systems/pull/15
>>
>> Thanks for looking into this, Andreas.  No more broken builds have been
>> reported[1], so apparently we're good! :)
>>
>> [1] <https://news-web.php.net/php.doc.pt-br>
>>
>> Cheers,
>> Christoph
>>
>