[libGD] #92 [Comment added] imagearc/imagefilledarc DoS fix problem

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#92 - imagearc/imagefilledarc DoS fix problem
User who did this - Claes Månsson (cj)

----------
A digression perhaps: I'm not sure what the best behaviour would be. One thing that strikes me, is that the start/end angle way of providing drawing instructions can thought of as start angle + revolution angle instead. 

They're perfectly possible to translate between, but the intent of start+revolution becomes a bit clearer, since there would be no way to misinterpret "how far" to draw the arcs. The start angle would always work using modulo 360, and here's how your examples could be done:

1. 10 + 10: arc from 10 to 20

2. 20 + 350: arc from 20 to 10 (through 0, large arc)

3. 0 + 360: full

4. 0 + 380: 0 ? 20 (overdrawn two times the last 20°? :)

5. 270 + 360: full (like 0 ? 360)

6. 270 + 0: nothing, equal before sanitization


See how the intent of case 5 and 6 becomes clearer?

I'm not saying that the calling interface should be changed, working in start+revs could be done internally.

But, I'm very new to imagearc/imagefilledarc, so I don't know how other people are using it, and what to expect from it.

I think I will be able to check the script, but it may take a little while for me to be able to do it.

Regards.

----------

More information can be found at the following URL:
http://bugs.libgd.org/?do=details&task_id=92#comment288

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.