Re: [GD-DEVEL] proper usage of entities.h

Hi,

On 2/12/07, Mike Frysinger <[email protected]> wrote:
> On Monday 12 February 2007, Pierre wrote:
> > On 2/12/07, Mike Frysinger <[email protected]> wrote:
> > > On Monday 12 February 2007, Mike Frysinger wrote:
> > > > the entities.h header seems kind of an odd duck for exportation to
> > > > users of GD ... if you have a project that includes it, then every
> > > > object file will get its own copy of the large structure which can
> > > > cause some problems
> > > >
> > > > since the contents of the entities array/structure shouldnt be assumed
> > > > to be static (eg you can assume index 0 is always AElig), is there a
> > > > good reason for exporting the definition ?
> >
> > Why one would use it? It is not supposed to be used/included directly.
> > It is a private definition. ABI should not matter here.
>
> if that's the case, then the header should not be installed and its symbol
> should be removed from the exported ABI
>
> > Have you seen any applications relying on this file?
>
> graphviz
>
> > If yes, do you have any suggestion to make it really private?
>
> removing the header from installation would get us 90% of the way there ;)


If it solves the issues, I'm 200% in favour of removing it (as well as
any other private files) and fix the codes if necessary.

I will wait other persons opinion (Lars and other linux packagers)
before to apply the change. It will probably be done in 2.1.0 as I do
not think it should be done in 2.0.35 or?

About entities, I realized that I had to regenerate it manually before
the release. The definition should have been static "static struct
entities_s". entities.tcl is updated but not enitites.h (generated by
entities.tcl).

If you can open an issue about this problem, it will help me to do not
forget it (or I can do it but you will not be noticed of the changes)
:)

Thanks for the suggestions and feedbacks,

--Pierre