Re: [GD-DEVEL] The PTHREADS support detection is broken
[email protected] (Lars Hecking)
| Newsgroups | php.gd.devel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, 01 Jan 2007 20:47:01 +0100, Jonas Smedegaard writes: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > > The detection of PTHREADS support is broken. See > http://bugs.debian.org/268280 for more info. > > The attached patch (together with the libtools cleanup suggested in an > earlier post) should fix this issue. > > I believe this to be safe to apply for 2.0.34. My apologies for the belated reply. I was only now able to track down the correct email address of the macro author. Here's his response: | From: "Steven G. Johnson" <[email protected]> | To: Lars Hecking <[email protected]> | Subject: Re: acx_pthread | Date: Tue, 29 Jan 2008 12:54:30 -0500 | | The patch is incorrect. The ACX_PTHREAD macro is supposed to restore the | original LIBS and CFLAGS upon exiting according to its documentation, so | the original version of the macro is correct. If the user wants to add | $PTHREAD_LIBS to the global $LIBS, she is responsible for doing so herself, | as documented. So, if there are any changes necessary, they must be made outside the ACX_PTHREAD context as we should not deviate from the upstream code.