[GIT-PULLS] [php-src] PR #22985: Applied fixers to improve test robustness (ext/intl, ext/phar)
[email protected] (NickSdot) Sat, 1 Aug 2026 08:13:29 +0000
| Newsgroups | php.git-pulls |
|---|---|
| Message-ID | <[email protected]> |
Pull Request: https://github.com/php/php-src/pull/22985 Author: NickSdot Hey! As requested in https://github.com/php/php-src/pull/22799#issuecomment-5124595234 I carry over commits into separate PRs for extensions. This was cherry picket from https://github.com/php/php-src/pull/22799 (where the deterministic proof is). Regarding style-only concerns, I manually reviewed the diff here: - one (1) single line is purely style-only, out of 1,033 touched lines. - 20 lines merge `echo` & `var_dump()` to the normalised `echo` (Daniel explicitly mentioned no objections to it). - comma vs. period style question is sorted, because the PR uses what is already today the most used style in `php-src` (see https://github.com/php/php-src/pull/22799#issuecomment-5122585858); as proposed by Daniel. The more individual extension PRs are merged, the smaller the diff in then main PR, the easier to review. Merging this one will decrease diff size in the main PR by ~1,000 lines (~6%), and will decrease its affected files by 250 files (~9%).