[GIT-PULLS] [php-src] PR #23108: ext/zip: addGlob() and addPattern() ignore their default options.
[email protected] (devnexen)
| Newsgroups | php.git-pulls |
|---|---|
| Message-ID | <sV4G7ZidDoVdS789sQBjStAGHiDNpJMX71CSJNoptIU@main.internal.php.net> |
Pull Request: https://github.com/php/php-src/pull/23108 Author: devnexen php_zip_parse_options() held the defaults but only ran for a non-empty options array, so opts stayed zeroed otherwise: comp_method 0 is CM_STORE and flags 0 drops FL_OVERWRITE. Entries were therefore stored uncompressed, and an already present entry name failed the call instead of being replaced. The defaults now live in PHP_ZIP_DEFAULT_OPTIONS, applied at declaration.