[GIT-PULLS] [php-src] PR #23319: ext/zip: Fix AES-192 and AES-256 support reporting in phpinfo()
[email protected] (LamentXU123)
| Newsgroups | php.git-pulls |
|---|---|
| Message-ID | <mXY9SilUau0MTIjqwy0faEjvRLo4VgfJsc8eaum2hY4@main.internal.php.net> |
Pull Request: https://github.com/php/php-src/pull/23319 Author: LamentXU123 I am speechless. I firstly thought my environment is broken because I seem to be testing my patch on a libzip version that doesn't support all the aes method, and after hours of researching, I find out that phpinfo() shows the wrong constant. ``` php_info_print_table_row(2, "AES-128 encryption", zip_encryption_method_supported(ZIP_EM_AES_128, 1) ? "Yes" : "No"); php_info_print_table_row(2, "AES-192 encryption", zip_encryption_method_supported(ZIP_EM_AES_128, 1) ? "Yes" : "No"); php_info_print_table_row(2, "AES-256 encryption", zip_encryption_method_supported(ZIP_EM_AES_128, 1) ? "Yes" : "No"); ``` What can I say.