[GIT-PULLS] [php-src] PR #23518: LDAP Object Oriented API
[email protected] (MCMic)
| Newsgroups | php.git-pulls |
|---|---|
| Message-ID | <AVkycT8l4tGswxIPavCpontS2QCITwoEMgvP3FBL800@main.internal.php.net> |
Pull Request: https://github.com/php/php-src/pull/23518 Author: MCMic Adding some methods to the LDAP objects to have an object oriented API. The PHP warnings are replaced by Exception throwing. Open questions and TODOs: - [ ] Add an Exception class for php-ldap insead of throwing `Error`. - [ ] Should the result object store the link to the ldap connection? That would allow `$result->parse(…` to replace `ldap_parse_result($connection, $result, …`. - [ ] Implement `Traversable` in result entries. - [ ] There is no way to get back the URI that was used to create a connection. `There is ldap_get_option($conn LDAP_OPT_HOST_NAME`, but it does not return the full URI. Should we store the string URI in the object and add either a getter or a public-readonly property? This property would also appear in debugInfo output, helping with debug and testing. - [ ] Write an RFC with the proposed OO API