com gtk/php-gtk: GtkWidget::drag_dest_find_target( ) needs to return a duplicate to avoid a bu ffer overflow in zend_variables (under doze, anyway). Let me know if any other platforms suffer as a result of this fix. There are relevant tests scripts for DND in the test d irectory.: ext/gtk+/gtkdrag.overrides

[email protected] (David Soria Parra) Sat, 17 Jun 2006 21:55:52 +0000

Newsgroups	php.gtk.cvs
Message-ID	<[email protected]>

Commit:    9779111ab9c7f169aac98cac30def523b684f6d5
Author:    Steph Fox <[email protected]>         Sat, 17 Jun 2006 21:55:52 +0000
Parents:   2b0fd261a6fb6bc7e3d2753c423a23a1b89217ff
Branches:  master

Link:       http://git.php.net/?p=gtk/php-gtk.git;a=commitdiff;h=9779111ab9c7f169aac98cac30def523b684f6d5

Log:
GtkWidget::drag_dest_find_target() needs to return a duplicate to avoid a buffer overflow in zend_variables (under doze, anyway).
Let me know if any other platforms suffer as a result of this fix. There are relevant tests scripts for DND in the test directory.

Changed paths:
  M  ext/gtk+/gtkdrag.overrides


Diff:
9779111ab9c7f169aac98cac30def523b684f6d5
diff --git a/ext/gtk+/gtkdrag.overrides b/ext/gtk+/gtkdrag.overrides
index daca98a..914dfc5 100644
--- a/ext/gtk+/gtkdrag.overrides
+++ b/ext/gtk+/gtkdrag.overrides
@@ -209,7 +209,7 @@ PHP_METHOD
         gtk_target_list_unref(tlist);
     }
 
-    RETURN_STRING(gdk_atom_name(atom), 0);
+    RETURN_STRING(gdk_atom_name(atom), 1);
 }
 
 %%