com gtk/php-gtk: Title was being free'd too early: ext/gtk+/gtk.overrides

[email protected] (David Soria Parra) Wed, 19 Oct 2005 18:54:52 +0000
Newsgroups php.gtk.cvs
Message-ID <[email protected]>
Commit:    ab10d82c0135bb8f813439808159d1606b2569ca
Author:    Steph Fox <[email protected]>         Wed, 19 Oct 2005 18:54:52 +0000
Parents:   4219ab6cc4976091d3fa6f45ef5e4ba538d6dffe
Branches:  master

Link:       http://git.php.net/?p=gtk/php-gtk.git;a=commitdiff;h=ab10d82c0135bb8f813439808159d1606b2569ca

Log:
Title was being free'd too early

Changed paths:
  M  ext/gtk+/gtk.overrides


Diff:
ab10d82c0135bb8f813439808159d1606b2569ca
diff --git a/ext/gtk+/gtk.overrides b/ext/gtk+/gtk.overrides
index 55a6afe..e885bca 100644
--- a/ext/gtk+/gtk.overrides
+++ b/ext/gtk+/gtk.overrides
@@ -708,8 +708,6 @@ PHP_METHOD
 
     wrapped_obj = (GObject *)g_object_new(phpg_gtype_from_zval(this_ptr), NULL);
 
-    if (free_title) g_free(title);
-
     if (!wrapped_obj) {
         PHPG_THROW_CONSTRUCT_EXCEPTION(GtkDialog);
     }
@@ -717,6 +715,8 @@ PHP_METHOD
     if (title) {
         gtk_window_set_title(GTK_WINDOW(wrapped_obj), title);
     }
+    if (free_title) g_free(title);
+
     if (parent) {
         gtk_window_set_transient_for(GTK_WINDOW(wrapped_obj), parent);
     }