Bug #50888 [Opn->Asn]: Patch Request: Detection of Microsoft VS.NET 2008

Edit report at http://bugs.php.net/bug.php?id=50888&edit=1

 ID:               50888
 Updated by:       [email protected]
 Reported by:      thomas dot worm at thomas-worm dot de
 Summary:          Patch Request: Detection of Microsoft VS.NET 2008
-Status:           Open
+Status:           Assigned
 Type:             Bug
 Package:          PHP-GTK related
 Operating System: Windows
 PHP Version:      5.3.1
-Assigned To:      
+Assigned To:      kalle

 New Comment:

Assigned to myself, I got a patch which detects the other missing MSVC
versions along with a few other improvements to the Windows build of
GTK.


Previous Comments:
------------------------------------------------------------------------
[2010-01-30 21:15:51] thomas dot worm at thomas-worm dot de

Description:
------------
When you compile PHP-GTK with Microsoft VS.NET 2008 the compiler will 
not be detected properly.

This could be fixed with following patch:


diff -ruN php-gtk.orig/win32/config.w32.in php-gtk/win32/config.w32.in
--- php-gtk.orig/win32/config.w32.in	2010-01-16 19:02:31.074820100 
+0100
+++ php-gtk/win32/config.w32.in	2010-01-16 19:05:17.334329600 +0100
@@ -40,6 +40,9 @@
 	if (VCVERS == 14) {
 		msversion = "Microsoft VS.NET 2005";
 	}
+	if (VCVERS == 15) {
+		msversion = "Microsoft VS.NET 2008";
+	}
 	STDOUT.WriteLine("Detected compiler version:  " + msversion);
 
 } else {

Reproduce code:
---------------
cscript /nologo configure.js

Expected result:
----------------
Detected compiler version: Microsoft VS.NET 2008

Actual result:
--------------
Detected compiler version:  unknown


------------------------------------------------------------------------



-- 
Edit this bug report at http://bugs.php.net/bug.php?id=50888&edit=1