Re: op_array.opcode restructure patch
[email protected] (Mark Skilbeck) Sun, 30 May 2010 21:21:56 +0100
| Newsgroups | php.gtk.dev,php.gtk.dev |
|---|---|
| Message-ID | <[email protected]> |
On 26/05/10 12:35, Elizabeth M Smith wrote: > On 5/25/2010 3:31 PM, Mark Skilbeck wrote: >> See: http://svn.php.net/viewvc?view=revision&revision=298203 >> >> The above revision adds an extra parameter (const struct _zend_literal >> *key) to the following function pointers: >> http://svn.php.net/viewvc/php/php-src/trunk/Zend/zend_object_handlers.h?r1=298203&r2=298202&pathrev=298203 >> >> >> > > Does that need a version check ifdef around it? These changes are only > in HEAD and php-gtk has to compile against 5.2 and 5.3 as well... > > Thanks, > Elizabeth That's a good point. However, I'm not sure what that check would look like. How do you check for compilation of trunk? -- Mark Skilbeck mahcuz.com | gtk.php.net | pecl.php.net/cairo | docs.php.net