Re: [PHP-GTK-DEV] Yes, particularly Glade3

--e89a8f234d09dc4e8b0519d1c380
Content-Type: text/plain; charset=UTF-8

On Tue, Jun 30, 2015 at 11:49 AM, Gage Morgan <[email protected]>
wrote:

> Hey, good afternoon, Ben:
>
> I've updated the README with two different Linux methods for installation
> of PHP-GTK2: One for those who want a dedicated PHP install, or those who
> would rather apply a patch and move on. Despite Ubuntu-specific, on other
> Linux systems the commands would either be the same or they would be only
> slightly different.
>
> I created a patch with diff:
>

Gage,

Thanks for the README patch. I have a couple recommendations for changes:

You mention that Cairo should be checked out using Subversion. However, the
Subversion repository listed is old and no longer maintained. Cairo's main
repository is now on GitHub, so your instructions should be updated to
clone from the Git repository instead. The Cairo PECL extension source is
now located here: https://github.com/gtkforphp/cairo

Likewise, you mention checking out the php-gtk source from a Subversion
repository. This repository no longer exists and has been migrated to Git.
Please update your instructions to show cloning from the Git repository.
The primary upstream repository URL is
https://git.php.net/repository/php/gtk-src.git (see also
http://git.php.net/?p=php/gtk-src.git;a=summary), but you may also chose to
use the GitHub URL for convenience: https://github.com/php/php-gtk-src.
I'll leave that up to you.

What does the SquirrelsHatesRobots patch do for php-gtk2? You need to make
it clear why you're suggesting the use of the SquirrelsHatesRobots patch; I
would prefer not to advocate the use of a third-party patch in the main
project README, unless it's absolutely necessary. Is this a patch that
should be merged into the primary project repository? It looks like it's a
single line addition to build2/build2.mk.

Cheers,
Ben

--e89a8f234d09dc4e8b0519d1c380--