RE: [PHP-GTK-DEV] Yes, particularly Glade3
[email protected] (Gage Morgan) Wed, 1 Jul 2015 18:07:02 -0400
| Newsgroups | php.gtk.dev |
|---|---|
| Message-ID | <[email protected]> |
--_f4492437-0895-4ad4-9b15-8d55f8a17d21_ Content-Type: multipart/alternative; boundary="_e6c2ce30-7d49-4cb1-80cf-17bbb0f337c1_" --_e6c2ce30-7d49-4cb1-80cf-17bbb0f337c1_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Good Evening=2C Ben! I removed the patch instructions for SquirrelsHateRobots as well as updated= the URLs and modified some of the text to fit in without the usage of the = SquirrelsHateRobots patch. It is included in this email. > Date: Wed=2C 1 Jul 2015 10:13:28 -0500 > From: [email protected] > To: [email protected] > CC: [email protected] > Subject: Re: [PHP-GTK-DEV] Yes=2C particularly Glade3 >=20 > On Tue=2C Jun 30=2C 2015 at 11:49 AM=2C Gage Morgan <[email protected]= om> > wrote: >=20 > > Hey=2C good afternoon=2C Ben: > > > > I've updated the README with two different Linux methods for installati= on > > of PHP-GTK2: One for those who want a dedicated PHP install=2C or those= who > > would rather apply a patch and move on. Despite Ubuntu-specific=2C on o= ther > > Linux systems the commands would either be the same or they would be on= ly > > slightly different. > > > > I created a patch with diff: > > >=20 > Gage=2C >=20 > Thanks for the README patch. I have a couple recommendations for changes: >=20 > You mention that Cairo should be checked out using Subversion. However=2C= the > Subversion repository listed is old and no longer maintained. Cairo's mai= n > repository is now on GitHub=2C so your instructions should be updated to > clone from the Git repository instead. The Cairo PECL extension source is > now located here: https://github.com/gtkforphp/cairo >=20 > Likewise=2C you mention checking out the php-gtk source from a Subversion > repository. This repository no longer exists and has been migrated to Git= . > Please update your instructions to show cloning from the Git repository. > The primary upstream repository URL is > https://git.php.net/repository/php/gtk-src.git (see also > http://git.php.net/?p=3Dphp/gtk-src.git=3Ba=3Dsummary)=2C but you may als= o chose to > use the GitHub URL for convenience: https://github.com/php/php-gtk-src. > I'll leave that up to you. >=20 > What does the SquirrelsHatesRobots patch do for php-gtk2? You need to mak= e > it clear why you're suggesting the use of the SquirrelsHatesRobots patch= =3B I > would prefer not to advocate the use of a third-party patch in the main > project README=2C unless it's absolutely necessary. Is this a patch that > should be merged into the primary project repository? It looks like it's = a > single line addition to build2/build2.mk. >=20 > Cheers=2C > Ben = --_e6c2ce30-7d49-4cb1-80cf-17bbb0f337c1_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable <html> <head> <style><!-- .hmmessage P { margin:0px=3B padding:0px } body.hmmessage { font-size: 12pt=3B font-family:Calibri } --></style></head> <body class=3D'hmmessage'><div dir=3D'ltr'>Good Evening=2C Ben!<div><br></d= iv><div>I removed the patch instructions for SquirrelsHateRobots as well as= updated the URLs and modified some of the text to fit in without the usage= of the SquirrelsHateRobots patch. It is included in this email.</div><div>= <br><br><div>>=3B Date: Wed=2C 1 Jul 2015 10:13:28 -0500<br>>=3B From: = [email protected]<br>>=3B To: [email protected]<br>>=3B CC: php-gt= [email protected]<br>>=3B Subject: Re: [PHP-GTK-DEV] Yes=2C particularl= y Glade3<br>>=3B <br>>=3B On Tue=2C Jun 30=2C 2015 at 11:49 AM=2C Gage = Morgan &[email protected]>=3B<br>>=3B wrote:<br>>=3B <br>&g= t=3B >=3B Hey=2C good afternoon=2C Ben:<br>>=3B >=3B<br>>=3B >=3B= I've updated the README with two different Linux methods for installation<= br>>=3B >=3B of PHP-GTK2: One for those who want a dedicated PHP instal= l=2C or those who<br>>=3B >=3B would rather apply a patch and move on. = Despite Ubuntu-specific=2C on other<br>>=3B >=3B Linux systems the comm= ands would either be the same or they would be only<br>>=3B >=3B slight= ly different.<br>>=3B >=3B<br>>=3B >=3B I created a patch with diff= :<br>>=3B >=3B<br>>=3B <br>>=3B Gage=2C<br>>=3B <br>>=3B Thanks= for the README patch. I have a couple recommendations for changes:<br>>= =3B <br>>=3B You mention that Cairo should be checked out using Subversio= n. However=2C the<br>>=3B Subversion repository listed is old and no long= er maintained. Cairo's main<br>>=3B repository is now on GitHub=2C so you= r instructions should be updated to<br>>=3B clone from the Git repository= instead. The Cairo PECL extension source is<br>>=3B now located here: ht= tps://github.com/gtkforphp/cairo<br>>=3B <br>>=3B Likewise=2C you menti= on checking out the php-gtk source from a Subversion<br>>=3B repository. = This repository no longer exists and has been migrated to Git.<br>>=3B Pl= ease update your instructions to show cloning from the Git repository.<br>&= gt=3B The primary upstream repository URL is<br>>=3B https://git.php.net/= repository/php/gtk-src.git (see also<br>>=3B http://git.php.net/?p=3Dphp/= gtk-src.git=3Ba=3Dsummary)=2C but you may also chose to<br>>=3B use the G= itHub URL for convenience: https://github.com/php/php-gtk-src.<br>>=3B I'= ll leave that up to you.<br>>=3B <br>>=3B What does the SquirrelsHatesR= obots patch do for php-gtk2? You need to make<br>>=3B it clear why you're= suggesting the use of the SquirrelsHatesRobots patch=3B I<br>>=3B would = prefer not to advocate the use of a third-party patch in the main<br>>=3B= project README=2C unless it's absolutely necessary. Is this a patch that<b= r>>=3B should be merged into the primary project repository? It looks lik= e it's a<br>>=3B single line addition to build2/build2.mk.<br>>=3B <br>= >=3B Cheers=2C<br>>=3B Ben<br></div></div> </div></body> </html>= --_e6c2ce30-7d49-4cb1-80cf-17bbb0f337c1_-- --_f4492437-0895-4ad4-9b15-8d55f8a17d21_--