RE: [INTERNALS-WIN] FreeLibrary(GetModuleHandle(…))?

Hi Jan,

> -----Original Message-----
> From: Jan Ehrhardt <[email protected]>
> Sent: Monday, June 11, 2018 11:19 AM
> To: [email protected]
> Cc: [email protected]
> Subject: Re: [INTERNALS-WIN] FreeLibrary(GetModuleHandle(…))?
> 
> Hi Anatol,
> 
> Anatol Belski in php.internals.win (Mon, 11 Jun 2018 07:33:01 +0000):
> >FreeModule is not be used on a handle retrieved by GetModuleHandle(),
> >so we definitely have to do with a bug here. Especially in the thread
> >safe build it's dangerous. On different Windows versions the system
> >loader differs in its smartness, so it can handle it a different way.
> 
> This trigered me to retest my build-dist for
> https://bugs.php.net/bug.php?id=76443 under Windows 10. Result: no segfault.

Thanks for checking. Any inappropriate FreeLibrary calls should be now fixed in 7.2 and master, so far I could find them.

Regards

Anatol