Re: [INTERNALS-WIN] Unbundling of libsqlite

Hi Anatol!

On 22.09.2018 at 21:07, Anatol Belski wrote:

>> -----Original Message-----
>> From: Christoph M. Becker <[email protected]>
>> Sent: Saturday, September 22, 2018 3:10 PM
>> To: internals-win <[email protected]>
>> Subject: [INTERNALS-WIN] Unbundling of libsqlite
>>
>> While working on unbundling libsqlite, I've stumbled upon the undocumented
>> Windows only configuration option --with-pdo-sqlite-external[1], which appears
>> to build the pdo_sqlite_external extension.  Is this even supported, or could it be
>> removed for master?
>
> If the bundled sources are not needed anymore, it's always an external to be linked. I don't remember seeing any usage of that option, probably it would make sense to just remove it in favor of the usual external items lookup without name change to the extension dll.  
> 
>> Another question: how can I check whether a certain function is available in
>> config.w32 (i.e. how to replace the autoconf macro PHP_CHECK_LIBRARY)?
>
> There's a function CHECK_FUNC_IN_HEADER in configure.js. Though, such a check likely not to be needed. In most case we'd assume the official deps are used. Plus, this functionality is just being introduced, so there is no need for BC. Thus, KISS is reasonable.

My question was also related to request #41502[1]; this feature had been
implemented long ago, but did only ever work for bundled libsqlite,
because it was checking a compile time macro.  I have already a working
fix for *nix, that checks for the availability of
`sqlite3_column_table_name()`, but this check would also need to be done
for the Windows `--with-pdo-sqlite-external` option.  Initially, I'd
wanted to treat the issue as bug and fix it for 7.1+, but since the
status of `--with-pdo-sqlite-external` isn't clear, I think it is best
to fix it for master only, after libsqlite has been unbundled.

> FYI I've added SQLite3 builds to the master staging series, usable both locally and with CI. Please let me know, if there are any issues with these builds.

Great news!  I'll check that out as soon as possible.

[1] <https://bugs.php.net/bug.php?id=41502>

-- 
Christoph M. Becker