RE: [INTERNALS-WIN] chDir, chDrive, #35691
[email protected] ("Andi Gutmans")
| Newsgroups | php.internals.win |
|---|---|
| Message-ID | <[email protected]> |
Can you share the patch before committing? This is pretty touchy stuff and we need to make sure we don't break anything else (incl. performance) when we put this in. Thanks, Andi > -----Original Message----- > From: Elizabeth M Smith [mailto:[email protected]] > Sent: Monday, June 23, 2008 7:41 AM > To: Rob Richards > Cc: Pierre Joye; [email protected] > Subject: Re: [INTERNALS-WIN] chDir, chDrive, #35691 > > Rob Richards wrote: > > Hi Pierre, > > > > Pierre Joye wrote: > >> Hi! > >> > >> Please take a look at #35691 (http://bugs.php.net/bug.php?id=35691), > >> my last comment. > >> > >> I would prefer to add chdrive to keep chdir behaviors consistent with > >> the posix/win32 behaviors. But it makes the code less portable. > >> > >> > > imo, I think chdrive should be added and chdir behavior kept as it is. > > > > Rob > > > > > chdrive + keep chdir as is currently sounds good to me - commit ;) > > -- > Windows Internals Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php