Re: [INTERNALS-WIN] Build environment notes (single CRT)
[email protected] ("Steph Fox")
| Newsgroups | php.internals.win |
|---|---|
| Message-ID | <011601c963a4$4051aa50$3ffc1f3e@foxbox> |
While we at it...
> var php_usual_lib_suspects = PHP_PHP_BUILD+"\\lib;..\\bindlib_w32";
>
> should read something like:
>
> var php_usual_lib_suspects = PHP_PHP_BUILD+"\\lib;..\\bindlib_w32\\" +
> Status;
... the reason I hadn't noticed this-all before is that PHP_PHP_BUILD falls
back to 'no' if the 'win32build' directory (or friend) doesn't exist. It
still does this in 5_3 and HEAD:
if (FSO.FolderExists("..\\win32build")) {
PHP_PHP_BUILD = "..\\win32build";
} else if (FSO.FolderExists("..\\php-win32-dev\\php_build")) {
PHP_PHP_BUILD = "..\\php-win32-dev\\php_build";
}
Would it ruin anybody's life if there were a fallback to '..'?
if (FSO.FolderExists("..\\win32build")) {
PHP_PHP_BUILD = "..\\win32build";
} else if (FSO.FolderExists("..\\php-win32-dev\\php_build")) {
PHP_PHP_BUILD = "..\\php-win32-dev\\php_build";
} else {
PHP_PHP_BUILD = "..";
}
I'm not the only person to have mentioned this in the past. The only
workaround (apart from specifying --with-php-build=whatever every time) is
to add the paths to include, lib, bin and bindlib_w32 into the MSVS
batchfile that sets the paths, which - being lazy - is exactly what I did.
But obviously that only works when you don't have any weird paths to deal
with, and the minute you build something with a weird path you get this mad
error message about some directory named 'no', so you're back to having to
specify --with-php-build again.
I can't see how it would break anything to have '..' as a fallback - does
anyone know otherwise? (I'm not sure how it'd work out with your setup f.e.,
Pierre?)
- Steph