Re: [INTERNALS-WIN] Build environment notes (single CRT)

On Sun, Dec 21, 2008 at 8:42 PM, Steph Fox <[email protected]> wrote:
> While we at it...
>
>> var php_usual_lib_suspects = PHP_PHP_BUILD+"\\lib;..\\bindlib_w32";
>>
>> should read something like:
>>
>> var php_usual_lib_suspects = PHP_PHP_BUILD+"\\lib;..\\bindlib_w32\\" +
>> Status;

Status being debug or?

> ... the reason I hadn't noticed this-all before is that PHP_PHP_BUILD falls
> back to 'no' if the 'win32build' directory (or friend) doesn't exist. It
> still does this in 5_3 and HEAD:
>
>  if (FSO.FolderExists("..\\win32build")) {
>   PHP_PHP_BUILD = "..\\win32build";
>  } else if (FSO.FolderExists("..\\php-win32-dev\\php_build")) {
>   PHP_PHP_BUILD = "..\\php-win32-dev\\php_build";
>  }
>
> Would it ruin anybody's life if there were a fallback to '..'?
>
>  if (FSO.FolderExists("..\\win32build")) {
>   PHP_PHP_BUILD = "..\\win32build";
>  } else if (FSO.FolderExists("..\\php-win32-dev\\php_build")) {
>   PHP_PHP_BUILD = "..\\php-win32-dev\\php_build";
>  } else {
>   PHP_PHP_BUILD = "..";
>  }
>
> I'm not the only person to have mentioned this in the past.

Never heard any complain about that and I do not think adding the
"parent directory" by default brings us anything good.

> But obviously that only works when you don't have any weird paths to deal
> with, and the minute you build something with a weird path you get this mad
> error message about some directory named 'no', so you're back to having to
> specify --with-php-build again.

And that's exactly the goal of this option, to deal with weird
configs/paths. So no, I'm not in favor of adding ".." to the list. It
is not like it takes hours to add the option anyway (1min to write a
myconf,bat, on a slow laptop ;) ).

Cheers,
-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org