Re: [INTERNALS-WIN] mail() sending local hostname instead of fully-qualified hostname as HELO
[email protected] (Rick Yorgason)
| Newsgroups | php.internals.win |
|---|---|
| Message-ID | <[email protected]> |
Hey Kalle, Your new patch still works for me, but I haven't really tested your new code, because I can't think of any way to convince gethostname to return an IP address. Actually, is that isdigit check really necessary? The docs for gethostname specify that "it is guaranteed that the name returned will be successfully parsed by gethostbyname". -Rick- Kalle Sommer Nielsen wrote: > Hi again > > 2009/6/23 Rick Yorgason <[email protected]>: >> +1 to the patch. > > I revised the patch, and its available here: > http://pastie.org/522368 > > It also takes if gethostname returns an ip into account, with support > for IPv6 address if php is compiled with IPv6 support. Let me know if > the patch still passes on your machine by using this patch. (Patched > for PHP_5_3) > >