Re: [INTERNALS-WIN] mail() sending local hostname instead of fully-qualified hostname as HELO
[email protected] (Kalle Sommer Nielsen)
| Newsgroups | php.internals.win |
|---|---|
| Message-ID | <[email protected]> |
Hi Rick 2009/6/26 Rick Yorgason <[email protected]>: > http://pastie.org/525609 > > I've tested it by forcing ent->h_name to an IPv4 or IPv6 number, and all > three scenarios (including not forcing it) seem to provide valid data. The only two minor issues I see now is that we need to include: #include "win32/inet.h" for inet functions if the compiler system lacks of it. And the other being we need to wrap the IPv6 stuff out in an ifdef block, as users can disable IPv6 support using --disable-ipv6, so its just a simple: #ifdef HAVE_IPV6 but else I think the patch is good and ready to be committed once our freeze is over. If you don't get around to fix those items then I will before I commit. -- regrads, Kalle Sommer Nielsen [email protected]