Re: [INTERNALS-WIN] Re: Patch for Bug #48831 php -i has different output to php --ini
[email protected] (Richard Quadling)
| Newsgroups | php.internals.win |
|---|---|
| Message-ID | <[email protected]> |
2009/9/2 Pierre Joye <[email protected]>: > hi Richard, > > The logic in the patch looks right, however I don't you need to export > again php_ini_scanned_path as it is exported already in php.ini.c. > Maybe check if it could be added to the header instead? > > Cheers, > > On Mon, Aug 24, 2009 at 3:19 PM, Richard > Quadling<[email protected]> wrote: >> 2009/8/24 Richard Quadling <[email protected]>: >>> Hi. >>> >>> Having got all the build tools now and I can actually test the code, >>> here is a patch for Bug#48831. >>> >>> Regards, >>> >>> Richard Quadling. >>> >>> >>> -- >>> ----- >>> Richard Quadling >>> "Standing on the shoulders of some very clever giants!" >>> EE : http://www.experts-exchange.com/M_248814.html >>> Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731 >>> ZOPA : http://uk.zopa.com/member/RQuadling >>> >> >> And here is the dropped (thanks Keisial) attachment. >> >> Hopefully. >> >> -- >> ----- >> Richard Quadling >> "Standing on the shoulders of some very clever giants!" >> EE : http://www.experts-exchange.com/M_248814.html >> Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731 >> ZOPA : http://uk.zopa.com/member/RQuadling >> >> -- >> Windows Internals Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > > > -- > Pierre > > http://blog.thepimp.net | http://www.libgd.org > I was copying the code from ext/standard/info.c It seemed like the route of least change. I REALLY am a beginner here. Wherever the externs (declared in main/php_ini.c) are called, they are always accessed via the PHPAPI extern char *xxxx mechanism. I don't feel comfortable changing this. -- ----- Richard Quadling "Standing on the shoulders of some very clever giants!" EE : http://www.experts-exchange.com/M_248814.html Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731 ZOPA : http://uk.zopa.com/member/RQuadling