Re: [INTERNALS-WIN] RE: svn: /php/php-src/branches/PHP_5_3/TSRM/ tsrm_win32.c
[email protected] (Pierre Joye)
| Newsgroups | php.internals.win |
|---|---|
| Message-ID | <[email protected]> |
hi, On Fri, Sep 4, 2009 at 8:41 AM, Christian Wenz<[email protected]> wrote: > Hi, > > and apologies if I overlook something obvious, but shouldn´t "asuser" be > initialized with TRUE instead of FALSE (line 321)? It should yes, damned :) Thanks for the head up! For the record here, the reason for this fix is described in http://bugs.php.net/49458: It works on 2008/Vista/Win7 but fails on XP or 2k3. It seems that CreateProcessAsUser is more restrictive in these versions than in newer releass forcing us to check for ERROR_NO_TOKEN. If the current thread is not impersonated, it has no token assigned. > It seems to work in my custom build, however I have some other > modifications in, so I might be completely off the track, as well ;-) There are two modes to test, with or impersonate enabled. I did not test the later yesterday (wanted that fix in RC1). Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org