Re: [INTERNALS-WIN] end of support for VC6 in trunk
[email protected] (Pierre Joye)
| Newsgroups | php.internals.win |
|---|---|
| Message-ID | <[email protected]> |
hi, Applied. On Sun, Oct 4, 2009 at 6:16 PM, Pierre Joye <[email protected]> wrote: > hi William, > > On Tue, Sep 22, 2009 at 11:07 PM, William A. Rowe, Jr. > <[email protected]> wrote: >> William A. Rowe, Jr. wrote: >>> Pierre Joye wrote: >>>>> Since the whole mod_php SetIni is not threadsafe, >>>> What are you refering to here? :) >>> >>> Just looking at sapi/apache_hooks, it >>> seems that ini processing changed significantly between 5.2 and 5.3. >> >> I'm evaluating this, it may take a couple days to get my head around >> the code since I had a couple other urgent items on my plate right now. >> If I see any issues, I'll sound off this coming week. > > I may have found something that could cause issues in TS SAPI, inside > the php.ini management code. > > We were initializing a static point to the GetSystemWindowsDirectory > function, without worrying about concurrent access (init time). As > this function is available now in our minimal windows versions, I > simply use GetSystemWindowsDirectory directly instead of using > LoadLibrary and GetProcAddress. > > Patch attached. > > Cheers, > -- > Pierre > > http://blog.thepimp.net | http://www.libgd.org > -- Pierre http://blog.thepimp.net | http://www.libgd.org